Remove AccountManagerException.MissingKeyFromSyncScopedAccessToken exception
Categories
(Firefox for Android :: Accounts and Sync, enhancement, P3)
Tracking
()
People
(Reporter: bdk, Unassigned)
References
Details
(Whiteboard: [group1][fxdroid])
This exception was set up to catch scenario where we have requested the sync scope (https://identity.mozilla.com/apps/oldsync) and have received an access token, but not the sync key that should accompany it.
However, application-services added its own check for this and now throws FxaExceptionSyncScopedKeyMissingInServerResponse when it sees the issue.
This means that AccountManagerException.MissingKeyFromSyncScopedAccessToken is no longer used and can be removed. The sentry data mostly backs this up, although there is a handful of events left in the 30-day view, probably from version 120. Once these go down to 0, let's remove the exception.
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
|
||
Comment 1•1 year ago
|
||
Hey Ben, was about to pull this in and I checked the sentry data that you link and it appears that we still quite a few events that are getting sent from here. Is this still something that is safe to remove?
|
Reporter | |
Comment 2•1 year ago
|
||
I'm trying to remember all the context here, but it looks like I wasn't correct that we are handling all the errors in app-services. I think you should keep that exception and continue monitoring it.
|
|
||
Comment 3•6 months ago
|
||
Hey :bdk, it still looks like we're seeing a few of these. Should we close this for now or is there another issue we can block this issue with?
|
|
Reporter | |
Comment 4•6 months ago
|
||
There are a few, but it looks like they're all from slightly older builds. The discover tab seems to say the last a-s nightly was 2025-09-12, which was just before we merged a change to start using the new a-s state machine. I think that change might have removed the last corner cases to trigger the issue.
I personally think the exception could be removed. However, a main point of that state-machine change was to clarify code ownership. From my POV, the Android team owns the FxA code in android-components code and however you want to deal with this is good with me.
Description
•