18700 - Need to map ERROR_OPERATION_ABORTED

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Wan-Teh Chang]

The Win32 error code ERROR_OPERATION_ABORTED is returned
when an overlapped I/O operation is canceled.  Our Win32
error mapping function _MD_win32_map_default_error() needs
to map this error code.

Comment 1

[Wan-Teh Chang]

I propose that we add the NSPR error code:
    PR_OPERATION_ABORTED_ERROR
with the default error message:
    "The I/O operation was aborted"
and map ERROR_OPERATION_ABORTED to this
error.

Alternatively, we could map ERROR_OPERATION_ABORTED
to PR_PENDING_INTERRUPTED_ERROR, but I think that
would overload the meaning of PR_PENDING_INTERRUPT_ERROR.

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch. Use the reserved error code -5935.

Comment 3

[srinivas]

It is better to use PR_OPERATION_ABORTED_ERROR, rather than overload the meaning 
of interrupted error.

Comment 4

[Wan-Teh Chang]

I checked in the patch to NSPRPUB_RELEASE_4_0_BRANCH.
A new error code, PR_OPERATION_ABORTED_ERROR, is added.
It uses the previously reserved error code value -5935.

/cvsroot/mozilla/nsprpub/pr/include/prerr.h, revision 3.4.42.1
/cvsroot/mozilla/nsprpub/pr/src/md/windows/win32_errors.c, revision 3.6.18.1
/cvsroot/mozilla/nsprpub/pr/src/misc/prerr.c, revision 3.4.58.1
/cvsroot/mozilla/nsprpub/pr/src/misc/prerr.et, revision 3.3.58.1
/cvsroot/mozilla/nsprpub/pr/src/misc/prerr.properties, revision 3.2.58.1