1870085 - Generalize gfxAlphaRecovery vectorization

Status: RESOLVED FIXED

(Core :: Graphics: Text, task)

Description

[[:sergesanspaille]]

gfxAlphaRecovery has an SSE2 implementation, written using intrinsic, but no AVX nor Neon implementation. We already ship xsimd that would be a good fit for the job, providing both genericity and improved readability.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1870085 - Generalize gfxAlphaRecovery simd implementation r=jrmuizel!

Also get rid of unused code in the process.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50dcd8b0416d
Generalize gfxAlphaRecovery simd implementation r=jrmuizel,gfx-reviewers

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/50dcd8b0416d

Comment 4

[Jeff Muizelaar [:jrmuizel]]

We should back this out until the regressions are sorted.

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out as req by jrmuizel for causing regressions

Backout link: https://hg.mozilla.org/integration/autoland/rev/83353941eb9c338663b66d5b7092bd64f306f777

Comment 6

[[:sergesanspaille]]

I've submitted an update to https://phabricator.services.mozilla.com/D196459 that should fix the issue that caused the backout.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6059c0599889
Generalize gfxAlphaRecovery simd implementation r=jrmuizel,gfx-reviewers

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6059c0599889