1870224 - Closed tab is not displayed at first in the Recently closed tabs card

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 2023-12-15_10h38_09.mp4

Affected versions

• Nightly 122.0a1

Affected platforms

• Windows 10x64, macOS 13, Ubuntu 22

Steps to reproduce

1. Launch Firefox and reach Firefox View Next Recently Closed Tabs section
2. Close a tab
3. Observe the closed tab in the Recently Closed Tabs card

Expected result

• Item is displayed with url title and time stamp

Actual result

• Closed tab is not displayed at first in the Recently closed tabs card

Regression range

• First bad: 2023-12-13
• Last good:2023-12-12
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f823ab1d9a00b627089b75899e588823b584a9c4&tochange=b74ed8e9d95a8907add8dd764ccc89be1c7ab99d

Additional notes

• Closed tab is displayed in the Recently closed tabs card after a few seconds

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:Gabi, could you try to find a regression range using for example mozregression?

Comment 2

[Donal Meehan [:dmeehan]]

:kcochrane from the pushlog Bug 1857634 looks like a likely regressor. (Please correct me if needed)

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1870224 - Ensure card-container visibility is updated when recently closed items are updated in Fx View r=sclements

Comment 4

[Kelly Cochrane [:kcochrane]]

Comment on attachment 9368868 [details]
Bug 1870224 - Ensure card-container visibility is updated when recently closed items are updated in Fx View r=sclements

Beta/Release Uplift Approval Request

• User impact if declined: The first recently closed tab will not show as expected initially in Firefox View
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow steps from video attachment
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small change in Firefox View
• String changes made/needed: N/A
• Is Android affected?: No

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4afba3e9019
Ensure card-container visibility is updated when recently closed items are updated in Fx View r=sclements,fxview-reviewers,sfoster

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e4afba3e9019

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9368868 [details]
Bug 1870224 - Ensure card-container visibility is updated when recently closed items are updated in Fx View r=sclements

Approved for 122.0b2

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba289ed4a863

Comment 9

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed in Firefox 122.0b2 and Firefox 123.0a1 Windows 10, Ubuntu and macOS 11.