Closed
Bug 187030
Opened 22 years ago
Closed 21 years ago
tocDS variable is not declared
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: brant, Assigned: oeschger)
Details
Attachments
(1 file, 1 obsolete file)
693 bytes,
patch
|
alecf
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20021226 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20021226 The tocDS variable is no declared. Reproducible: Always Steps to Reproduce: 1. Open the Help Viewer Actual Results: Warning: assignment to undeclared variable tocDS Source File: chrome://help/content/help.js Line: 245 Expected Results: No warning. Strict warnings must be on.
Reporter | ||
Comment 1•22 years ago
|
||
I simply replaced an assignment with a declared assignment. That is tocDS = something; became var tocDS = something; The length of the patch is due to the fact that my text editor strips trailing whitespace which is unnecessary and adds size.
Reporter | ||
Comment 2•22 years ago
|
||
Comment on attachment 110287 [details] [diff] [review] one-line patch adding var before assignment I don't have the necessary CVS access to check this in once it is reviewed so somebody needs to check it in once it is reviewed.
Attachment #110287 -
Flags: review?(oeschger)
Reporter | ||
Comment 3•22 years ago
|
||
I manually added the patched file to my help.jar and ran Mozilla. No error appears now openning Help once or more. I also ran the prechecking tests without issues.
Assignee | ||
Comment 4•22 years ago
|
||
Comment on attachment 110287 [details] [diff] [review] one-line patch adding var before assignment r=oeschger
Attachment #110287 -
Flags: review?(oeschger) → review+
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•22 years ago
|
||
You gonna put this in yourself? I don't think I have access to these files for updating via gila.
Assignee | ||
Comment 6•22 years ago
|
||
I will try and get this in myself, Brant. I am trying to put some of these small fixes together so I can check them in all at once.
Reporter | ||
Comment 7•22 years ago
|
||
Any idea when you will check in these and the other fixes? I'd like to do some work and make sure nothing I do has been done or gets duplicated or obsoleted.
Reporter | ||
Comment 8•21 years ago
|
||
Attachment #110287 -
Attachment is obsolete: true
Reporter | ||
Updated•21 years ago
|
Attachment #120116 -
Flags: superreview?(alecf)
Comment 9•21 years ago
|
||
Comment on attachment 120116 [details] [diff] [review] one-line patch (cleaner than the other since trailing whitespace wasn't stripped) sr=alecf
Attachment #120116 -
Flags: superreview?(alecf) → superreview+
Assignee | ||
Comment 10•21 years ago
|
||
FIXED.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•