187030 - tocDS variable is not declared

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Brant Gurganus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20021226
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20021226

The tocDS variable is no declared.

Reproducible: Always

Steps to Reproduce:
1. Open the Help Viewer
Actual Results:  
Warning: assignment to undeclared variable tocDS
Source File: chrome://help/content/help.js
Line: 245

Expected Results:  
No warning.

Strict warnings must be on.

Comment 1

[Brant Gurganus]

Attachment: one-line patch adding var before assignment

I simply replaced an assignment with a declared assignment.  That is
tocDS = something;

became

var tocDS = something;

The length of the patch is due to the fact that my text editor strips trailing
whitespace which is unnecessary and adds size.

Comment 2

[Brant Gurganus]

Comment on attachment 110287 [details] [diff] [review]
one-line patch adding var before assignment

I don't have the necessary CVS access to check this in once it is reviewed so
somebody needs to check it in once it is reviewed.

Comment 3

[Brant Gurganus]

I manually added the patched file to my help.jar and ran Mozilla.  No error
appears now openning Help once or more.  I also ran the prechecking tests
without issues.

Comment 4

[Ian Oeschger (gone)]

Comment on attachment 110287 [details] [diff] [review]
one-line patch adding var before assignment

r=oeschger

Comment 5

[Brant Gurganus]

You gonna put this in yourself?  I don't think I have access to these files for
updating via gila.

Comment 6

[Ian Oeschger (gone)]

I will try and get this in myself, Brant. I am trying to put some of these small
fixes together so I can check them in all at once.

Comment 7

[Brant Gurganus]

Any idea when you will check in these and the other fixes?  I'd like to do some
work and make sure nothing I do has been done or gets duplicated or obsoleted.

Comment 8

[Brant Gurganus]

Attachment: one-line patch (cleaner than the other since trailing whitespace wasn't stripped)

Comment 9

[Alec Flett]

Comment on attachment 120116 [details] [diff] [review]
one-line patch (cleaner than the other since trailing whitespace wasn't stripped)

sr=alecf

Comment 10

[Ian Oeschger (gone)]

FIXED.

Comment 11

[R.J. Keller]

VERIFIED