1870574 - [about:logins] The “Remove” button is misplaced in Edit Mode

Status: RESOLVED FIXED

(Firefox :: about:logins, defect)

Description

[Anca Soncutean, Desktop QA]

Attachment: screenshoot issue.png

Found in

• 122.0a1

Affected versions

• 122.0a1

Affected platforms

• Windows 10
• macOS 13
• Ubuntu 22

Steps to reproduce

1. Open about:logins
2. Add a login for any website
3. While the saved login is in focus, enter “Edit” mode
4. Observe the “Remove” button

Expected result

• The “Remove” button is aligned with “Save” and “Cancel” buttons.

Actual result

• The “Remove” button is slightly above Save and Cancel buttons.

Regression range

• First bad: 10278e294b9cc514d6e271abffa4f37dff7cf678
• Last good: c98598f88f9d71061733bf4c96a7891071de5966
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c98598f88f9d71061733bf4c96a7891071de5966&tochange=10278e294b9cc514d6e271abffa4f37dff7cf678
• Potentially regressed by: 1844869

Additional notes

• The functionality is not affected

Comment 1

[BugBot [:suhaib / :marco]]

:asoncutean, could you try to find a regression range using for example mozregression?

Comment 2

[BugBot [:suhaib / :marco]]

:ssachdev, since you are the author of the regressor, bug 1844869, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Sidharth Sachdev]

Attachment: Bug 1870574 - [about:logins] The “Remove” button is misplaced in Edit Mode. r=issammani!

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1844869

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99abc216c643
[about:logins] The “Remove” button is misplaced in Edit Mode. r=issammani DONTBUILD

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/99abc216c643

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:ssachdev, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Anca Soncutean, Desktop QA]

Verified fixed in Nightly 123.0a1 (2024-01-08) on Windows 10, macOS 13 and Ubuntu 22.