1870634 - [wpt-sync] Sync PR 43705 - webrtc: add setParameterOptions to sender.setParameters

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43705 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43705
Details from upstream follow.

Philipp Hancke <[e-mail]> wrote:

webrtc: add setParameterOptions to sender.setParameters

adding a new RTCSetParameterOptions object which has a sequence of
RTCEncodingOptions similar to
WebCodecs VideoEncoderEncodeOptions
https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions
and its keyFrame flag.

On the native side, this adds the request_key_frame flag to the
RtpEncodingParameters.

WebRTC CL:
https://webrtc-review.googlesource.com/c/src/+/286741
Spec PRs:
https://github.com/w3c/webrtc-pc/pull/2885
https://github.com/w3c/webrtc-extensions/pull/167

BUG=chromium:1354101

Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242
Reviewed-on: https://chromium-review.googlesource.com/4643591
WPT-Export-Revision: 180a863e4ae53ae2c032246582295414954d15bb

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e977412f492d19899f4dbec33412bc32c2da357

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
PASS: 1
FAIL: 1

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/RTCRtpSender-setParameters-keyFrame.html [wpt.fyi]
  • setParameters() second argument can be used to trigger keyFrame generation: FAIL (Chrome: FAIL, Safari: FAIL)
  • setParameters() second argument can be used to trigger keyFrame generation (simulcast): FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5420b6c9c31
[wpt PR 43705] - webrtc: add setParameterOptions to sender.setParameters, a=testonly
https://hg.mozilla.org/integration/autoland/rev/51e792d1884e
[wpt PR 43705] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f5420b6c9c31
https://hg.mozilla.org/mozilla-central/rev/51e792d1884e