1870642 - The "Collection deleted" snack bar overlaps the toolbar

Status: RESOLVED FIXED

(Firefox for Android :: Collections, defect, P3)

Description

[Delia Pop (Android QA)]

Attachment: processed-9951ad1d-249b-43ee-96c3-267178cd4c47_vhJLP1St.jpeg

Preconditions

1. Set the toolbar placement to "Bottom".
2. Create a collection.

Steps to reproduce

1. From homepage > Collections, expand the collection.
2. Tap the 3 dot menu and select "Delete collection".
3. Observe the snack bar placement.

Expected behavior

The snack bar is displayed above the toolbar.

Actual behavior

The snack bar is displayed overlapping the toolbar.

Device information

• Firefox version: Nightly 122.0a1 from 12/18, Beta 121.0b9, RC 121.0 build 2
• Android device model: Motorola Moto G30
• Android OS version: Android 13

Any additional information?

Reproducible with any device and on older Firefox for Android versions as well.

Comment 1

[Rebeca Tudor]

Attachment: Bug 1870642 - Fix Collection deleted snackbar that overlaps the toolbar

When a collection was deleted, the snackbar that contains the undo
button was overlapping the search toolbar.

The issue was that there wasn't a view to anchor the snackbar.
The fix was only to change the anchorView attribute from the function
allowUndo from null to snackbarAnchorView.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad446301fd33
Fix Collection deleted snackbar that overlaps the toolbar r=android-reviewers,007

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ad446301fd33

Comment 4

[Lorand Janos]

Managed to reproduce on the latest Beta 125.0b9 build.
Verified as fixed on the latest Nightly build (126.0a1 from 2024-04-09).
The snack bar is now displayed above the toolbar.
Device used: Samsung Galaxy S23 Ultra (Android 14).
Marking the ticket as verified on 126.

Comment 5

[Lorand Janos]

Attachment: d1c86ed3-82e3-4769-a941-518ee9d34f0d.jpg

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please don't close the bug when your patch lands on autoland. Bugs aren't considered fixed until they reach mozilla-central and we have automation which handles closing the bugs at that point and making sure that all appropriate metadata is set.

Comment 7

[Rebeca Tudor]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Please don't close the bug when your patch lands on autoland. Bugs aren't considered fixed until they reach mozilla-central and we have automation which handles closing the bugs at that point and making sure that all appropriate metadata is set.

I understand now! Thank you for letting me know!