1870665 - ./mach wpt fails with "not enough values to unpack (expected 3, got 1)"

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

Error running mach:

    mach wpt

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file wpt`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ValueError: not enough values to unpack (expected 3, got 1)

  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/mach_commands.py", line 557, in run_wpt
    return run_web_platform_tests(command_context, **params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/mach_commands.py", line 545, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/mach_commands_base.py", line 42, in run
    self.update_manifest(logger)
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/mach_commands_base.py", line 65, in update_manifest
    return manifestupdate.run(
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/manifestupdate.py", line 136, in run
    manifestdownload.download_from_taskcluster(
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/manifestdownload.py", line 227, in download_from_taskcluster
    return download_manifest(
           ^^^^^^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/manifestdownload.py", line 169, in download_manifest
    commits = commits_func()
              ^^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/manifestdownload.py", line 230, in <lambda>
    lambda: get_commits(logger, repo_root),
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/testing/web-platform/manifestdownload.py", line 40, in get_commits
    base_rev = repo.base_ref
               ^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/python/mozversioncontrol/mozversioncontrol/__init__.py", line 712, in base_ref
    official_remote = self.get_mozilla_upstream_remote()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jrmuizel/source/gecko-inbound/python/mozversioncontrol/mozversioncontrol/__init__.py", line 703, in get_mozilla_upstream_remote
    name, url, action = line.split()
    ^^^^^^^^^^^^^^^^^

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jgraham, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[James Graham [:jgraham]]

I can't reproduce this bug, does it still happen for you? From the traceback it looks like we're getting data in an unexpected format from git, which suggests maybe either a temporary error, or some unhandled edge case in possible git remote -v output.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

It still happens.

Here's my git remote -v output:

aosmond	https://github.com/aosmond/gecko (fetch)
aosmond	https://github.com/aosmond/gecko (push)
aurora	hg::https://hg.mozilla.org/releases/mozilla-aurora (fetch)
aurora	hg::ssh://hg.mozilla.org/releases/mozilla-aurora (push)
autoland	hg::https://hg.mozilla.org/integration/autoland (fetch)
autoland	hg::ssh://hg.mozilla.org/integration/autoland (push)
bas	hg::https://hg.mozilla.org/users/bschouten_mozilla.com/advanced-layers/ (fetch)
bas	hg::https://hg.mozilla.org/users/bschouten_mozilla.com/advanced-layers/ (push)
beta	hg::https://hg.mozilla.org/releases/mozilla-beta (fetch)
beta	hg::ssh://hg.mozilla.org/releases/mozilla-beta (push)
bgirard	https://github.com/bgirard/gecko-dev (fetch)
bgirard	https://github.com/bgirard/gecko-dev (push)
central	hg::https://hg.mozilla.org/mozilla-central (fetch)
central	hg::https://hg.mozilla.org/mozilla-central (push)
chunmin	https://github.com/ChunMinChang/gecko-dev (fetch)
chunmin	https://github.com/ChunMinChang/gecko-dev (push)
elm	hg::https://hg.mozilla.org/projects/elm (fetch)
elm	hg::ssh://hg.mozilla.org/integration/elm (push)
esr68	hg::https://hg.mozilla.org/releases/mozilla-esr68/ (fetch)
esr68	hg::https://hg.mozilla.org/releases/mozilla-esr68/ (push)
gfx	hg::https://hg.mozilla.org/projects/graphics/ (fetch)
gfx	hg::ssh://hg.mozilla.org/projects/graphics/ (push)
hawkman	hawkman.corp.tor1.mozilla.com:src/gecko (fetch)
hawkman	hawkman.corp.tor1.mozilla.com:src/gecko (push)
inbound	hg::https://hg.mozilla.org/integration/mozilla-inbound (fetch)
inbound	hg::ssh://hg.mozilla.org/integration/mozilla-inbound (push)
jrmuizel	[e-mail]:jrmuizel/gecko-cinnabar.git (fetch)
jrmuizel	[e-mail]:jrmuizel/gecko-cinnabar.git (push)
m1	10.cd (fetch)
m1	10.cd (push)
mstange	hg::https://hg.mozilla.org/users/mstange_themasta.com/mozilla-central/ (fetch)
mstange	hg::ssh://hg.mozilla.org/users/mstange_themasta.com/mozilla-central/ (push)
origin
pbo	hg::https://reviewboard-hg.mozilla.org/gecko/rev/d2ead546aa56cc87388da7121ea2377177a60102 (fetch)
pbo	hg::https://reviewboard-hg.mozilla.org/gecko/rev/d2ead546aa56cc87388da7121ea2377177a60102 (push)
release	hg::https://hg.mozilla.org/releases/mozilla-release (fetch)
release	hg::https://hg.mozilla.org/releases/mozilla-release (push)
review	hg::ssh://reviewboard-hg.mozilla.org/autoreview (fetch)
review	hg::ssh://reviewboard-hg.mozilla.org/autoreview (push)
reviewboard	hg::https://reviewboard-hg.mozilla.org/gecko (fetch)
reviewboard	hg::https://reviewboard-hg.mozilla.org/gecko (push)
ryzen	jrmuizel@ryzen:src/gecko (fetch)
ryzen	jrmuizel@ryzen:src/gecko (push)
try	hg::https://hg.mozilla.org/try (fetch)
try	hg::ssh://hg.mozilla.org/try (push)
wr-metal	https://github.com/zakorgy/gecko-dev (fetch)
wr-metal	https://github.com/zakorgy/gecko-dev (push)

Comment 4

[Jeff Muizelaar [:jrmuizel]]

It looks like it's the origin line that breaks it.

It comes from the following in my git config:

[remote "origin"]
        receivepack = powershell git receive-pack

I think it's probably there by mistake.

Removing it fixes the problem.

Comment 5

[James Graham [:jgraham]]

OK, well I think that mozversioncontrol could perhaps be updated to ignore lines that don't have a URL, given that seems to be possible to configure.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Mathew Hodson]

mozversioncontrol is categorized under Firefox Build System

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahochheiden, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Alex Hochheiden [:ahochheiden] [he/him]]

mstange	hg::ssh://hg.mozilla.org/users/mstange_themasta.com/mozilla-central/ (push)
origin
pbo	hg::https://reviewboard-hg.mozilla.org/gecko/rev/d2ead546aa56cc87388da7121ea2377177a60102 (fetch)

You have a remote just called origin that's not pointing to anything, which is the problem. You should be able to just run git remote remove origin and it should work.

If you want to reconfigure this origin, you can run:

git remote set-url origin <new-url>