1870824 - With offscreen canvas, Crash on https://codepen.io/frontsideup/pen/mgNNvx

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Mayank Bansal]

Use latest nightly
Go to https://codepen.io/frontsideup/pen/mgNNvx
Crash

Bug 1795296 - Enable Direct2D backend with OffscreenCanvas. r=gfx-reviewers,lsalzman

Differential Revision: https://phabricator.services.mozilla.com/D189533

2023-12-19T19:29:04.036000: DEBUG : Did not find a branch, checking all integration branches
2023-12-19T19:29:04.036000: INFO : The bisection is done.
2023-12-19T19:29:04.036000: INFO : Stopped

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

CP+[GFX1]: Failed to GetDataSurface in UpdateFromSurface (BT).
(#13) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#14) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#15) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#16) GP+[GFX1-]: Failed to get descriptor for recorded texture.
(#17) CP+[GFX1-]: Unexpected BufferProvider over-production.
(#18) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#19) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#20) CP+[GFX1]: Failed to GetDataSurface in UpdateFromSurface (BT).
(#21) CP+[GFX1-]: Unexpected BufferProvider over-production.
(#22) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#23) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#24) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#25) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#26) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001
(#27) GP+[GFX1-]: GFX: D3D11 lock failed 0x887a0001

Comment 3

[Mayank Bansal]

I dont get the crash now, but the browser can hang.
Try opening this URL in two tabs, then drag a tab into a new window and then try to drag it back: https://codepen.io/search/pens?q=offscreen+canvas&cursor=ZD0xJm89MCZwPTM=

Comment 4

[Mayank Bansal]

Unfortunately i deleted the crash report :(
It was something related to timeout or lock something.
Edit: The generated crash report bug 1709600 linked.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1795296

:aosmond, since you are the author of the regressor, bug 1795296, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Mayank Bansal]

I guess if you cant get a crash, the next best thing is to set gfx.canvas.remote.worker-threads=0 , and then try the two links in the above comments.

Comment 7

[Bob Hood [:bhood]]

Mayank, can you please provide a crash signature here?

Comment 8

[Mayank Bansal]

I didnt keep the crash signature when it happened, and then the patches were backed out.
Once the patches reland, i will retest and report any crashes.

Comment 9

[Pascal Chevrel:pascalc]

marking 123 fixed by backout

Comment 10

[Mayank Bansal]

Cant repro the crash on the latest Nightly. Looks like the relanded bug 1795296 / bug 1855742 fixed the issue here.

Comment 11

[Ina Popescu, Desktop QA]

I'm unable to replicate this issue in Nightly 123.0a1 (2023-12-19) on Windows 10 x64 following the STR from Comment 0 and Comment 3. Are there any prefs that I should enable? Thanks

Comment 12

[Mayank Bansal]

You will need to set gfx.canvas.remote.allow-offscreen = true.

However, please note that i got the crash only one time and couldn't repro the crash again..
And since then, there have been a ton more changes around canvas and offscreencanvas.
I would politely suggest to not spend much time in trying to reproduce the bug on nightlies
from tye date when i orginally filed this bug.

Comment 13

[Ina Popescu, Desktop QA]

Thank you for providing these details.
I am marking this as Verified Fixed, based on Comment 10 and Comment 12.