Closed Bug 1870882 Opened 1 year ago Closed 1 year ago

Showing the bookmarks toolbar should not resize the content area twice

Categories

(Firefox :: Bookmarks & History, defect)

defect

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(1 file)

When the bookmarks toolbar has a min-height (via https://searchfox.org/mozilla-central/rev/5920b970c9996c7820c7ebf4e7b072e77017edf2/toolkit/themes/windows/global/toolbar.css#20), showing the toolbar may resize the content area twice, the first time for showing the empty toolbar, the second time as bookmarks show up.

In customize mode, we do want a min-height. However this has stopped working:
https://searchfox.org/mozilla-central/rev/5920b970c9996c7820c7ebf4e7b072e77017edf2/browser/themes/shared/browser-shared.css#270-273
... because the toolbar is never really empty these days, e.g. there's a toolbartabstop element for keyboard access.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd8c805e629f Showing the bookmarks toolbar should not resize the content area twice. r=mak,desktop-theme-reviewers,emilio
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fda3e1f6690 Showing the bookmarks toolbar should not resize the content area twice. r=mak,desktop-theme-reviewers,emilio
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
Flags: needinfo?(dao+bmo)
Blocks: 1872477
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: