Closed Bug 1870883 Opened 2 years ago Closed 9 months ago

[meta] Logins encryption issues

Categories

(Application Services :: Logins, task, P3)

x86_64
macOS

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: teshaq, Unassigned)

References

Details

This is a meta bug tracking a few logins encryption issues related to empty ciphertexts

FYI 1866370 should probably be included here. For context, 1866370 is a bug for a failure within test_login_deletes which reports an EmptyCyphertext error after a logins record is deleted from the first client (which wipes that record's secFields) and then a sync is performed. Regardless of how or if these issues are linked, once the fixes are applied for the logins encryption issues, this test should pass.

Flags: needinfo?(teshaq)

Thank you so much Lougenia, you pointing out that other ticket was exactly what we needed to complete the story on what was going wrong.

There is a real case we fail to handle with regards to syncing logins, and I put up a PR in https://github.com/mozilla/application-services/pull/6011 to tackle it - it was quite subtle and unlikely... which explains why we have about 1000 users a day hitting it (out of the ~1 million) sync users we have on mobile!.. and once users hit it they are likely to stay in that condition.

Flags: needinfo?(teshaq)

Johannes, I know you're working on overhauling our encryption story as part of getting the Logins component into Desktop—I don't think there's anything necessarily actionable here yet, but CCing you just so you're aware!

All of the children here are closed. Closing this too.

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.