1870904 - Update PDF.js to new version 52ffd26da91c432e9afacd008b0b120621c45675 from 2023-12-18 14:04:32

Status: RESOLVED DUPLICATE of bug 1871996

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 8 commits. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/content/build/pdf.mjs | 10 +++++-----
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 ++--
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 6 +++---
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 4 ++--
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 6 +++---
toolkit/components/pdfjs/content/web/viewer.css | 4 ++--
toolkit/components/pdfjs/content/web/viewer.html | 4 ++--
toolkit/components/pdfjs/content/web/viewer.mjs | 6 +++---
toolkit/components/pdfjs/moz.yaml | 4 ++--
toolkit/locales/en-US/toolkit/pdfviewer/viewer.ftl | 3 +++
10 files changed, 27 insertions(+), 24 deletions(-)

---

933e107073b6e0ebd27660090f4a8bed4969d061 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/933e107073b6e0ebd27660090f4a8bed4969d061
Authored: 2023-12-18 15:01:19 +0100
Committed: 2023-12-18 15:01:19 +0100

Revert "Bump actions/upload-artifact from 3 to 4"

Files Modified:

• .github/workflows/publish_website.yml

---

25a0a68deff339faa6b5b4855ff9baa5ee611ef1 by dependabot[bot]

https://github.com/mozilla/pdf.js/commit/25a0a68deff339faa6b5b4855ff9baa5ee611ef1
Authored: 2023-12-18 12:39:30 +0000
Committed: 2023-12-18 12:39:30 +0000

Bump actions/upload-artifact from 3 to 4

Bumps actions/upload-artifact from 3 to 4.

• Release notes
• Commits

---

updated-dependencies:

• dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
  ...

Signed-off-by: dependabot[bot] <[e-mail]>

Files Modified:

• .github/workflows/publish_website.yml

---

2e82d947a61a2e929ff48204208105e3dcdd78af by dependabot[bot]

https://github.com/mozilla/pdf.js/commit/2e82d947a61a2e929ff48204208105e3dcdd78af
Authored: 2023-12-18 12:39:26 +0000
Committed: 2023-12-18 12:39:26 +0000

Bump github/codeql-action from 2 to 3

Bumps github/codeql-action from 2 to 3.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  ...

Signed-off-by: dependabot[bot] <[e-mail]>

Files Modified:

• .github/workflows/codeql.yml

---

f9a0d4efe8290dcb857d87f0888044041200d027 by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/f9a0d4efe8290dcb857d87f0888044041200d027
Authored: 2023-12-17 20:37:58 +0100
Committed: 2023-12-17 21:53:50 +0100

Modernize the rewriteWebArchiveUrl test helper function

This commit changes the code to use a template string and to use const
instead of var. Combined with the previous commits this allows for
enabling the ESLint no-var rule for this file now.

Files Modified:

• test/downloadutils.mjs

---

0a10a7b57b3aaa020283118e9f69c883dddc0863 by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/0a10a7b57b3aaa020283118e9f69c883dddc0863
Authored: 2023-12-17 20:26:53 +0100
Committed: 2023-12-17 21:53:50 +0100

Modernize the downloadManifestFiles/ensurePDFsDownloaded test helper functions

The test helper code largely predates the introduction of modern
JavaScript features and should be refactored to improve readability.
In particular callbacks make the code harder to understand and maintain.

This commit:

• replaces the callback argument with returning a promise;
• replaces the recursive function calls with a simple loop;
• uses const/let instead of var;
• uses arrow functions for shorter code;
• uses template strings for shorter string formatting code.

Files Modified:

• test/downloadutils.mjs
• test/test.mjs

---

86bee4409a51578503b548fad649a5b23ec50904 by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/86bee4409a51578503b548fad649a5b23ec50904
Authored: 2023-12-17 20:11:23 +0100
Committed: 2023-12-17 21:53:50 +0100

Modernize the downloadFile test helper function

The test helper code largely predates the introduction of modern
JavaScript features and should be refactored to improve readability.
In particular callbacks make the code harder to understand and maintain.

This commit:

• replaces the callback argument with returning a promise;
• uses const instead of var;
• uses arrow functions for shorter code;
• uses template strings for shorter string formatting code;
• uses Array.includes for shorter response code checking code.

Files Modified:

• test/downloadutils.mjs

---

12999127440201d177db1be106c40b741e501f39 by Jeremy Danyow

https://github.com/mozilla/pdf.js/commit/12999127440201d177db1be106c40b741e501f39
Authored: 2023-12-16 07:28:03 -0800
Committed: 2023-12-16 07:28:03 -0800

Center radio button checkmark

fixes #12238

Files Modified:

• web/annotation_layer_builder.css

---

eff8b2c67b9222d808f70ea37f19a5bdb839fd3d by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/eff8b2c67b9222d808f70ea37f19a5bdb839fd3d
Authored: 2023-12-11 17:20:56 +0100
Committed: 2023-12-12 19:57:38 +0100

[Editor] Add some missing strings to localize for highlighting

Files Modified:

• l10n/en-US/viewer.ftl
• web/viewer.html

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=061b018ea767fc41339be96dc1cf072523abd671

Comment 2

[Update Bot]

Attachment: Bug 1870904 - Update PDF.js to 52ffd26da91c432e9afacd008b0b120621c45675

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).