1870952 - Move libvpx files in libavcodec to non MOZ_FFVPX_AUDIOONLY builds

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P1)

Description

[C.M.Chang[:chunmin]]

The av_base64_encode in libvpxenc is exposed in non MOZ_FFVPX_AUDIOONLY builds only. The libvpx is for video, so its files shouldn't be included in the audio-only (MOZ_FFVPX_AUDIOONLY) builds.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1870952 - Move libvpx files to No MOZ_FFVPX_AUDIOONLY builds

The av_base64_encode in libvpxenc [1] is only exposed in non
MOZ_FFVPX_AUDIOONLY builds [2]. The libvpx is for video, so its files
shouldn't be built when in the audio-only (MOZ_FFVPX_AUDIOONLY) builds.

[1] https://searchfox.org/mozilla-central/rev/008ce958417fd724e02748740d669aafd49debb3/media/ffvpx/libavcodec/libvpxenc.c#1887
[2] https://searchfox.org/mozilla-central/rev/008ce958417fd724e02748740d669aafd49debb3/media/ffvpx/libavutil/avutil.symbols#6-9

Depends on D196925

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1870952 - Add sections for gkcodecs.symbols

This patch add sections for the symbols required in different libraries,
and alphabetize them in the sections.

Depends on D196929

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1575e2624e6b
Move libvpx files to No MOZ_FFVPX_AUDIOONLY builds r=media-playback-reviewers,jolin
https://hg.mozilla.org/integration/autoland/rev/f4b2bf9cc8f4
Add sections for gkcodecs.symbols r=media-playback-reviewers,jolin

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1575e2624e6b
https://hg.mozilla.org/mozilla-central/rev/f4b2bf9cc8f4