1870975 - Fix running updater tests locally on macOS

Status: NEW

(Toolkit :: Application Update, defect, P3)

Description

[Robin Steuber (she/her) [:bytesized]]

It looks like some (maybe all?) base updater tests (toolkit/mozapps/update/tests/unit_base_updater) fail when run locally with a popup that says

"dir.app" is damaged and can't be opened. You should move it to the Trash.

Just in case it isn't all of the tests failing, a specific one that is definitely failing locally for me is toolkit/mozapps/update/tests/unit_base_updater/marStageFailurePartial.js

I tried taking a look at the app bundle with codesign to see what's going on and got

> codesign -vvvv obj-unoptimized/_tests/xpcshell/toolkit/mozapps/update/tests/unit_base_updater/marStageFailurePartial/dir.app
obj-unoptimized/_tests/xpcshell/toolkit/mozapps/update/tests/unit_base_updater/marStageFailurePartial/dir.app: bundle format unrecognized, invalid, or unsuitable

I would have thought that the only real difference between running the test locally and on Try would be the signing, but that doesn't sound like a signing failure, so I'm a little confused.

Comment 1

[Nick Alexander :nalexander [he/him]]

I think I have this fixed locally; I'll try to get a try build rebased and pushed. I think this is essentially the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1724579.