update abseil to unbreak the build on OpenBSD
Categories
(Core :: WebRTC, defect)
Tracking
()
People
(Reporter: gaston, Assigned: mjf)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
gaston
:
feedback+
dmeehan
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-release+
|
Details | Review |
OpenBSD-current removed direct syscall
method, so the build of beta and central now fails in abseil (cf http://buildbot.rhaalovely.net/nine/#/builders/2/builds/1878/steps/8/logs/stdio):
98:57.18 /build/buildslave-amd64/mozilla-beta-amd64/build/third_party/libwebrtc/third_party/abseil-cpp/absl/base/internal/raw_logging.cc:238:3: error: use of undeclared identifier 'syscall'
98:57.18 syscall(SYS_write, STDERR_FILENO, s, len);
it's solved in our firefox port via a patch (cf https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/www/mozilla-firefox/patches/patch-third_party_libwebrtc_third_party_abseil-cpp_absl_base_internal_raw_logging_cc?rev=1.1&content-type=text/x-cvsweb-markup), which has been upstreamed in https://github.com/abseil/abseil-cpp/pull/1553 - what would it take to get that integrated in the abseil copy shipped in beta and central ? either by updating abseil, or just backporting that patch ?
Assignee | ||
Comment 2•1 year ago
|
||
Cherry-picks https://github.com/abseil/abseil-cpp/pull/1553
We should uplift this to beta and release.
Reporter | ||
Updated•1 year ago
|
Comment 4•1 year ago
|
||
bugherder |
Assignee | ||
Comment 5•1 year ago
|
||
Comment on attachment 9369908 [details]
Bug 1871006 - cherry-pick abseil-cpp #1553 to fix OpenBSD builds. r?ng!
Beta/Release Uplift Approval Request
- User impact if declined: Unable to build beta and release versions on OpenBDS
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce: n/a
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very low risk because it is removing a clause in an ifdef to disable a code use on OpenBSD
- String changes made/needed: n/a
- Is Android affected?: No
Comment 6•1 year ago
|
||
Comment on attachment 9369908 [details]
Bug 1871006 - cherry-pick abseil-cpp #1553 to fix OpenBSD builds. r?ng!
Approved for 122.0b4
Updated•1 year ago
|
Reporter | ||
Comment 8•1 year ago
|
||
m-b builds fine unpatched on OpenBSD, thanks !
Comment 9•1 year ago
|
||
Comment on attachment 9369908 [details]
Bug 1871006 - cherry-pick abseil-cpp #1553 to fix OpenBSD builds. r?ng!
Approved for 121.0.1
Comment 10•1 year ago
|
||
uplift |
Updated•1 year ago
|
Description
•