Closed Bug 1871006 Opened 1 year ago Closed 1 year ago

update abseil to unbreak the build on OpenBSD

Categories

(Core :: WebRTC, defect)

defect

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox121 --- fixed
firefox122 --- fixed
firefox123 --- fixed

People

(Reporter: gaston, Assigned: mjf)

Details

Attachments

(1 file)

OpenBSD-current removed direct syscall method, so the build of beta and central now fails in abseil (cf http://buildbot.rhaalovely.net/nine/#/builders/2/builds/1878/steps/8/logs/stdio):

98:57.18 /build/buildslave-amd64/mozilla-beta-amd64/build/third_party/libwebrtc/third_party/abseil-cpp/absl/base/internal/raw_logging.cc:238:3: error: use of undeclared identifier 'syscall'
98:57.18 syscall(SYS_write, STDERR_FILENO, s, len);

it's solved in our firefox port via a patch (cf https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/www/mozilla-firefox/patches/patch-third_party_libwebrtc_third_party_abseil-cpp_absl_base_internal_raw_logging_cc?rev=1.1&content-type=text/x-cvsweb-markup), which has been upstreamed in https://github.com/abseil/abseil-cpp/pull/1553 - what would it take to get that integrated in the abseil copy shipped in beta and central ? either by updating abseil, or just backporting that patch ?

Let me take a look at what we can do.

Assignee: nobody → mfroman
Attachment #9369908 - Flags: feedback+
Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6f389a38c4e cherry-pick abseil-cpp #1553 to fix OpenBSD builds. r=ng,webrtc-reviewers
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch

Comment on attachment 9369908 [details]
Bug 1871006 - cherry-pick abseil-cpp #1553 to fix OpenBSD builds. r?ng!

Beta/Release Uplift Approval Request

  • User impact if declined: Unable to build beta and release versions on OpenBDS
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: n/a
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very low risk because it is removing a clause in an ifdef to disable a code use on OpenBSD
  • String changes made/needed: n/a
  • Is Android affected?: No
Attachment #9369908 - Flags: approval-mozilla-release?
Attachment #9369908 - Flags: approval-mozilla-beta?

Comment on attachment 9369908 [details]
Bug 1871006 - cherry-pick abseil-cpp #1553 to fix OpenBSD builds. r?ng!

Approved for 122.0b4

Attachment #9369908 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

m-b builds fine unpatched on OpenBSD, thanks !

Comment on attachment 9369908 [details]
Bug 1871006 - cherry-pick abseil-cpp #1553 to fix OpenBSD builds. r?ng!

Approved for 121.0.1

Attachment #9369908 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: