Closed Bug 1871037 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 43746 - webrtc wpt: add legacy msid-semantic line to hardcoded sdp

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43746 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43746
Details from upstream follow.

Philipp Hancke <phancke@microsoft.com> wrote:

webrtc wpt: add legacy msid-semantic line to hardcoded sdp

which avoids an odd test failure from
https://webrtc-review.googlesource.com/c/src/+/331800

BUG=webrtc:10421

Change-Id: I144c5b6e90aa0e68be58518596839970743171ad
Reviewed-on: https://chromium-review.googlesource.com/5139143
WPT-Export-Revision: 828a952a7d27cdefcd17b6ac6abcf88a86288a04

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 14 tests and 22 subtests

Status Summary

Firefox

OK : 10[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt] 11[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 14[GitHub]
PASS : 45[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, GitHub] 48[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
FAIL : 30[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 36[GitHub]
TIMEOUT: 2
NOTRUN : 2

Chrome

OK : 13
PASS : 40
FAIL : 40
TIMEOUT: 2

Safari

OK : 10
PASS : 25
FAIL : 49
TIMEOUT: 8
NOTRUN : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /webrtc/simulcast/getStats.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Simulcast getStats results: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc/simulcast/rid-manipulation.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Remote reanswer altering rids does not throw an exception.: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Basic simulcast setup with three spatial layers: FAIL (Chrome: PASS, Safari: FAIL)
  • /webrtc/simulcast/h264.https.html [wpt.fyi]
    • H264 simulcast setup with two streams: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc/simulcast/negotiation-encodings.https.html [wpt.fyi]
    • addTrack, then sRD(simulcast recv offer) results in simulcast: FAIL (Chrome: FAIL, Safari: FAIL)
    • sRD(simulcast offer) can narrow the simulcast envelope from a previous negotiation: FAIL (Chrome: FAIL, Safari: FAIL)
    • Duplicate rids in sRD(offer) are ignored: FAIL (Chrome: FAIL, Safari: FAIL)
    • Choices in rids in sRD(offer) are ignored: FAIL (Chrome: FAIL, Safari: FAIL)
    • Reordering of rids in sRD(reoffer) is ignored: FAIL (Chrome: PASS, Safari: PASS)
    • sRD(simulcast offer) can narrow the simulcast envelope from a previous negotiation by removing the first encoding: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webrtc/simulcast/setParameters-active.https.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Simulcast setParameters active=false on first encoding stops sending frames for that encoding: PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], TIMEOUT [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt] (Chrome: PASS, Safari: PASS)
    • Simulcast setParameters active=false on second encoding stops sending frames for that encoding: NOTRUN [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
    • Simulcast setParameters active=false stops sending frames: NOTRUN [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
  • /webrtc/simulcast/setParameters-encodings.https.html [wpt.fyi]
    • Success task for setLocalDescription(answer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • Success task for setRemoteDescription(offer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: FAIL, Safari: FAIL)
    • Success task for setRemoteDescription(answer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: FAIL, Safari: FAIL)
  • /webrtc/simulcast/vp8.https.html [wpt.fyi]
    • VP8 simulcast setup with two streams: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc/simulcast/vp9-scalability-mode.https.html [wpt.fyi]
    • VP9 simulcast setup with two streams and L1T2 set: FAIL (Chrome: PASS, Safari: TIMEOUT)
  • /webrtc/simulcast/vp9.https.html [wpt.fyi]
    • VP9 simulcast setup with two streams: FAIL (Chrome: TIMEOUT, Safari: TIMEOUT)
  • /webrtc-extensions/RTCRtpParameters-codec.html [wpt.fyi]
    • Creating an audio sender with addTransceiver and codec should work: FAIL (Chrome: PASS, Safari: FAIL)
    • Creating a video sender with addTransceiver and codec should work: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting codec on an audio sender with setParameters should work: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting codec on a video sender with setParameters should work: FAIL (Chrome: PASS, Safari: FAIL)
    • Creating an audio sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Creating an audio sender with addTransceiver and non-existing codec type should throw OperationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Creating a video sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Creating a video sender with addTransceiver and non-existing codec type should throw OperationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting a non-existing codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting a non-existing codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting a non-preferred codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting a non-preferred codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting a non-negotiated codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Setting a non-negotiated codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
    • Codec should be undefined after negotiating away the currently set codec on an audio sender: FAIL (Chrome: PASS, Safari: FAIL)
    • Codec should be undefined after negotiating away the currently set codec on a video sender: FAIL (Chrome: PASS, Safari: FAIL)
    • Stats output-rtp should match the selected codec in non-simulcast usecase on an audio sender: FAIL (Chrome: PASS, Safari: TIMEOUT)
    • Stats output-rtp should match the selected codec in non-simulcast usecase on a video sender: FAIL (Chrome: PASS, Safari: NOTRUN)
    • Stats output-rtp should match the selected codec in simulcast usecase on a video sender: FAIL (Chrome: PASS, Safari: NOTRUN)
    • Stats output-rtp should match the selected mixed codecs in simulcast usecase on a video sender: FAIL (Chrome: FAIL, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

  • /webrtc/simulcast/getStats.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /webrtc/simulcast/rid-manipulation.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05300ae16afc [wpt PR 43746] - webrtc wpt: add legacy msid-semantic line to hardcoded sdp, a=testonly

https://hg.mozilla.org/mozilla-central/rev/05300ae16afc

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.