1871054 - Trending suggestions pref causes web search suggestions to be displayed for one letter inputs

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: one letter input search suggestions

Found in

• Fx 122.0b1

Affected versions

• Fx 122.0b1
• Fx 123.0a1

Affected platforms

• Windows 10
• Ubuntu 20.04
• macOS

Steps to reproduce

1. Launch Firefox.
2. Open a new tab and type 'z'.

Expected result

• NO web search suggestions are displayed for one letter input.

Actual result

• Web search suggestions are displayed for one letter input, which is only specific for trending suggestions feature, even though no trending suggestions are actually displayed.

Regression range

• Not a regression. Has been like this since the implementation of trending suggestions.

Additional notes

• Please note that this affects the balance of results shown (websearch suggestions vs firefox suggest). With trending enabled the firefox suggest results are drastically reduced (only 3 shown).
• With browser.urlbar.trending.featureGate disabled, there are no web search suggestions for 1 letter input.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:cbaica, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Mark Banner (:standard8)]

We should fix this before shipping trending suggestions, as it is unintentionally different behaviour.

Comment 3

[Dale Harvey (:daleharvey)]

I cant seem to be able to reproduce this, if I type one letter in the urlbar I get suggestions regardless of whether I type 1 letter or 3 and regardless of whether browser.urlbar.trending.featureGate is true or false

It seems like https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarUtils.sys.mjs#2255 could have caused this bug, but yeh not seeing 1 letter search suggestions being prevented regardless

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Bug 1871054 - Dont show suggestions for single character query. r=daisuke

Comment 5

[Dale Harvey (:daleharvey)]

Found it cheers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6da1eae794ef
Dont show suggestions for single character query. r=daisuke

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6da1eae794ef

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Bug 1871054 - Dont show suggestions for single character query. r=daisuke

Original Revision: https://phabricator.services.mozilla.com/D213774

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Minor UX regression
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Type one character in urlbar and observe if suggestions are fetched
• Risk associated with taking this patch: Minimal
• Explanation of risk level: Small fix to non complicated code path
• String changes made/needed: No
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/61587947fc85