1871106 - MD5HexFunction in SQLFunctions.cpp should be replaced with sha256 or removed

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

MD5HexFunction in SQLFunctions.cpp should be replaced with sha256 or removed if it's not used.

Comment 1

[Marco Bonardo [:mak]]

As it's only used in a not-yet-enabled feature, it should be fine to just do a plain replace. Though it should be done along with changes to PlacesPreviews.sys.mjs

The hash here is just used to map urls in a database to files on disk.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Hey Marco, we (the security engineering team) are working on removing deprecated hashes from the Firefox code base. I wanted to check in and ask if you could prioritize this bug? Could you maybe even provide a timeline?

We imagine the change shouldn't be too complicated. We could imagine that replacing md5 with e.g. sha256 could work, though we are happy to discuss options with you and the team. Thank you!

Comment 3

[Marco Bonardo [:mak]]

I'll take this

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1871106 - MD5HexFunction in SQLFunctions.cpp should be replaced with sha256 or removed. r=daisuke

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/504bf19a4b32
MD5HexFunction in SQLFunctions.cpp should be replaced with sha256 or removed. r=daisuke,places-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/504bf19a4b32