1871137 - bookmark_text using white color doesn't have text shadow anymore

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[fizzwidget]

Attachment: firefox_white_bookmark_120_121.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

Just using a theme with white text on the frame. For the test, I used "Have a fox dream" and "Furfox Tail Twister (light)"

Actual results:

Since Firefox 121, using a theme with "colors.tab_background_text: white" (or similar) doesn't render a text shadow for elements of bookmarks bar.

Expected results:

I think it should not change from the previous version (except if this a feature)

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello, thank you for the bug report!
Managed to reproduce this issue on:

• Firefox Nightly 123.0a1;
• Firefox 122.0b3;
• Firefox 121.0;

Tested and reproduced on:

• macOS 12;
• Windows 10;
• Ubuntu 22;

Setting as NEW so the developing team can have a look.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4d2c1911361bbc41f63b4e807070a3d83596b70c&tochange=eec6c72011b067e61a80469a9930d4027862a959

Comment 4

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1861020, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1871137 - Remove bogus rule from toolbarbutton.css. r=#theme

This comes from the windows version of toolbarbutton.css from before
bug 1861020, which had:

toolbarbutton:where([disabled="true"]) {
  color: GrayText;
  text-shadow: none;
}

@media not (prefers-contrast) {
  :root[lwtheme-image] toolbarbutton {
    text-shadow: none;
  }
}

:root[lwtheme-image] toolbarbutton:not([disabled="true"]) {
  text-shadow: inherit;
}

Which didn't make a lot of sense, but made the media-query block
basically useless.

It seems I noticed that:

:root[lwtheme-image] toolbarbutton:not([disabled="true"])

Was useless because of the disabled rule, but I didn't notice that that
would make the media block unexpectedly apply.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1ef003a39f1
Remove bogus rule from toolbarbutton.css. r=desktop-theme-reviewers,dao

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e1ef003a39f1

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9370494 [details]
Bug 1871137 - Remove bogus rule from toolbarbutton.css. r=#theme

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS change
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9370494 [details]
Bug 1871137 - Remove bogus rule from toolbarbutton.css. r=#theme

Approved for 122.0b5

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f90e924e68ea

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 121.0 on Windows 10.
Verified as fixed on Firefox 122.0b5 and Firefox Nightly 123.0a1 on Windows 10, macOS 12, Ubuntu 22.