1871210 - Add privileged means of determining what notification button was pressed.

Status: RESOLVED FIXED

(Toolkit :: Alerts Service, enhancement, P3)

Description

[Nick Rishel [:nrishel]]

We need a more general way to determine what notification action (button) was pressed when interacting with the in-memory callback.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1871210 - Extend `AlertNotification` with `WindowsAlertNotification` for custom handling of alert buttons on Windows. r=nalexander,mhughes

When nsIWindowsAlertNotification's handleActions property is set to true, actions are sent in the notification observer's aData field instead of the notification cookie.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e2969964030
Extend `AlertNotification` with `WindowsAlertNotification` for custom handling of alert buttons on Windows. r=nalexander,mhughes

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2e2969964030

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug XXX - Fix `ToastNotification` action handling regressed by Bug 1871210.

Generally, this shouldn't matter: background task notifications expect
to relaunch Firefox to handle them, and in that case handleActions
is not relevant; but it's still best to accommodate background tasks
that expect Windows 8.1 action callbacks, since it's easy to do so.

Depends on D199149

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug XXX - Fix `ToastNotification` action handling regressed by Bug 1871210.

Generally, this shouldn't matter: background task notifications expect
to relaunch Firefox to handle them, and in that case handleActions
is not relevant; but it's still best to accommodate background tasks
that expect Windows 8.1 action callbacks, since it's easy to do so.

Depends on D199152