Closed
Bug 187130
Opened 22 years ago
Closed 22 years ago
Remove #ifdef / #ifndef XP_OS2 in nsLocalFileOS2.cpp
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
|
14.79 KB,
patch
|
mkaply
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
nsLocalFileOS2.cpp is only built for OS/2 anyway, so the ifdefs seem unnecessary. I'll attach a patch shortly.
|
Assignee | |
Comment 1•22 years ago
|
||
While I were at it, I also removed an #if 0 block in nsLocalFileOS2.h, I hope that's ok; and I also changed a NS_ENSURE_ARG to NS_ENSURE_ARG_POINTER because it is a pointer.
|
|
Assignee | |
Updated•22 years ago
|
Attachment #110337 -
Flags: review?(mkaply)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 110337 [details] [diff] [review] patch I built this and made sure it works. Looks good. Thanks for the help.
Attachment #110337 -
Flags: review?(mkaply) → review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #110337 -
Flags: superreview?(bzbarsky)
|
||
Updated•22 years ago
|
Attachment #110337 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Comment 3•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•