1871347 - Don't pass a boolean aIsAnimValList to GetDOMWrapper when we can derive it

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Robert Longson [:longsonr]]

DOMSVGPointList::GetDOMWrapper and DOMSVGPathSegList::GetDOMWrapper take a boolean aIsAnimValList argument.

1. boolean arguments are problematical because it's easy to confuse them
2. we don't use the argument at all in the common case that the wrapper is found
3. we can derive the value we need from the other arguments
4. if you pass the wrong boolean value the function won't work at all.

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1871347 - Don't pass a boolean aIsAnimValList to GetDOMWrapper when we can derive it r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92e5593dff89
Don't pass a boolean aIsAnimValList to GetDOMWrapper when we can derive it r=emilio

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/92e5593dff89