1871386 - Move -Wl,-build-id from old-configure to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1871386 - Move -Wl,-build-id check from old-configure to moz.configure r=glandium!

As a side effect, give more room to the user concerning build-id
options.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cbb0162efb2
Move -Wl,-build-id check from old-configure to moz.configure r=glandium

Comment 3

[pstanciu]

Backed out for causing multiple failures on Linux asan opt

• Backout link
• Push with failures
• Failure Log
• Failure line:

[task 2024-02-06T11:12:33.635Z] 11:12:33    ERROR -  ==1324==ERROR: AddressSanitizer: odr-violation (0x559063d820c0):
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -    [1] size=40 'vtable for std::thread::_State' /builds/worker/checkouts/gecko/build/unix/stdc++compat/stdc++compat.cpp
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -    [2] size=40 'vtable for std::thread::_State' /builds/worker/checkouts/gecko/build/unix/stdc++compat/stdc++compat.cpp
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -  These globals were registered at these points:
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -    [1]:
[task 2024-02-06T11:12:33.659Z] 11:12:33     INFO -      #0 0x559063b014a6 in __asan_register_globals /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_globals.cpp:365:3
[task 2024-02-06T11:12:33.660Z] 11:12:33     INFO -      #1 0x559063d7e81e in asan.module_ctor stdc++compat.cpp
[task 2024-02-06T11:12:33.660Z] 11:12:33     INFO -      #2 0x559063d7e90c in __libc_csu_init (/builds/worker/workspace/build/tests/bin/xpcshell+0x35f90c)
[task 2024-02-06T11:12:33.661Z] 11:12:33     INFO -    [2]:
[task 2024-02-06T11:12:33.661Z] 11:12:33     INFO -      #0 0x559063b014a6 in __asan_register_globals /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_globals.cpp:365:3
[task 2024-02-06T11:12:33.662Z] 11:12:33     INFO -      #1 0x7f47719f7bfe in asan.module_ctor stdc++compat.cpp
[task 2024-02-06T11:12:33.663Z] 11:12:33     INFO -      #2 0x7f47718c7782  (/lib64/ld-linux-x86-64.so.2+0x10782) (BuildId: 822d3943c4bb51a173776d69a167a71a31522761)
[task 2024-02-06T11:12:33.663Z] 11:12:33     INFO -  ==1324==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
[task 2024-02-06T11:12:33.664Z] 11:12:33     INFO -  SUMMARY: AddressSanitizer: odr-violation: global 'vtable for std::thread::_State' at /builds/worker/checkouts/gecko/build/unix/stdc++compat/stdc++compat.cpp
[task 2024-02-06T11:12:33.664Z] 11:12:33     INFO -  ==1324==ABORTING
[task 2024-02-06T11:14:03.811Z] 11:14:03    ERROR - TEST-UNEXPECTED-FAIL | runtests.py | Timed out while waiting for server startup.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5bb3df23b07
Move -Wl,-build-id check from old-configure to moz.configure r=glandium

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a5bb3df23b07