18714 - citation and signature are quoted along with quoted text

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Akkana Peck]

In plaintext replies, the "xyz@abc wrote:" and the signature are included along
with the quoted text in what's passed to the editor's InsertAsQuotation, so they
come out with "> " in front of them.  They should be inserted separately so they
don't appear to be quoted.

Comment 1

[rhp (gone)]

I think I have the mail/news side done, but I think I'm blocked by some Ender
bugs that I'm waiting for feedback on. They have to do with setting the cursor
location and quoting behavior.

- rhp

Comment 2

[rhp (gone)]

Ok, I have this fixed in my tree so it does the right thing. Just working on
getting the cursor in the correct location when its at the end of the document.

- rhp

Comment 3

[rhp (gone)]

We are now doing the correct thing in the Compose back end so it should be 3
different inserts and the quoting should be correct. The only problem remaining
is  that data inserted after the InsertAsQuotation() call is being included as
part of the quotation still. The data is being quoted, but signatures are
ending up being quoted.

Passing this over to Akkana since I know you had a fix in the works for this.

- rhp

Comment 4

[Akkana Peck]

Back to you, Rich (though I think you already fixed this).

Comment 5

[Akkana Peck]

For some reason the reassign didn't "take".  Rich, I think this is already
fixed, but in case it isn't and you were waiting on the change of API for
InsertAsQuotation, I'm passing this back to you.

Comment 6

[rhp (gone)]

Hi Akkana,
The problem that I am seeing is that for HTML mail messages, the final insert
is being tacked on as part of the Quotation. For plain text email, the final
insert seems to get lost?

This is why I assigned this your way. Any ideas? Just assign it back if its
something I'm doing.

- rhp

Comment 7

[Akkana Peck]

You asked me to change the InsertAsQuotation API to pass back the blockquote or
pre node that was inserted, so that you could get that node and set the caret
before or after it depending on the mailnews pref.  I did that, and I thought
that was all you were waiting for.  If you wanted something else or if this
isn't working right, please let me know.

Comment 8

[rhp (gone)]

Ok, this is working now.

- rhp

Comment 9

[laurel]

OK using 12-14-11m12 commercial build linux 6.0
OK using 12-14-08m12 commercial build NT 4.0
OK using 12-14-08m12 commercial build Mac OS 8.5.1

xyz@abc is not contained within quoting.
A signature file, if in the message, is indeed quoted but that's how 4.x does
it, too.  If I'm misunderstanding the use of the word signature in this bug
description let me know... I'm going to mark this verified and if we need to
reopen or log another issue I/peter will.

Comment 10

[laurel]

Doh! Nevermind my last comment. All is well. Added signature file for current
reply author is not quoted. I must have been in the ozone the other day.