Closed Bug 1871557 Opened 2 years ago Closed 1 year ago

Intermittent Assertion failure: CompositorThreadHolder::IsInCompositorThread(), at /builds/worker/checkouts/gecko/gfx/layers/ipc/CompositorBridgeParent.cpp:356 | single tracking bug

Categories

(Core :: Graphics, defect, P5)

defect

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox-esr128 --- fixed
firefox130 --- wontfix
firefox131 --- wontfix
firefox132 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bradwerth)

References

Details

(Keywords: assertion, intermittent-failure, intermittent-testcase)

Crash Data

Attachments

(1 file, 2 obsolete files)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=441127275&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aT1ZB_TPRI-IR_v9wt4zEQ/runs/0/artifacts/public/logs/live_backing.log


[task 2023-12-22T12:12:51.128Z] 12:12:51     INFO - PID 22858 | Assertion failure: CompositorThreadHolder::IsInCompositorThread(), at /builds/worker/checkouts/gecko/gfx/layers/ipc/CompositorBridgeParent.cpp:356
[task 2023-12-22T12:12:51.144Z] 12:12:51     INFO - STDOUT: Initializing stack-fixing for the first stack frame, this may take a while...
[task 2023-12-22T12:12:51.256Z] 12:12:51     INFO - STDOUT: ============================= 43 passed in 11.59s ==============================
[task 2023-12-22T12:12:51.269Z] 12:12:51     INFO - mozcrash ...........................................
[task 2023-12-22T12:12:51.269Z] 12:12:51     INFO - mozcrash Copy/paste: /builds/worker/fetches/minidump-stackwalk/minidump-stackwalk --symbols-url=https://symbols.mozilla.org/ --cyborg=/tmp/tmpenqzpanh/568778a0-d06f-f2e2-4286-5c44fbfe830f.trace /tmp/tmp3zk43hix.mozrunner/minidumps/568778a0-d06f-f2e2-4286-5c44fbfe830f.dmp /builds/worker/workspace/build/symbols
[task 2023-12-22T12:12:55.524Z] 12:12:55     INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/568778a0-d06f-f2e2-4286-5c44fbfe830f.dmp
[task 2023-12-22T12:12:55.524Z] 12:12:55     INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/568778a0-d06f-f2e2-4286-5c44fbfe830f.extra
[task 2023-12-22T12:12:55.664Z] 12:12:55     INFO - PROCESS-CRASH | MOZ_ASSERT(CompositorThreadHolder::IsInCompositorThread()) [@ mozilla::layers::CompositorBridgeParent::StopAndClearResources] | /webdriver/tests/classic/is_element_enabled/enabled.py 
[task 2023-12-22T12:12:55.664Z] 12:12:55     INFO - Process type: main
[task 2023-12-22T12:12:55.664Z] 12:12:55     INFO - Process pid: 22921
[task 2023-12-22T12:12:55.664Z] 12:12:55     INFO - Mozilla crash reason: MOZ_ASSERT(CompositorThreadHolder::IsInCompositorThread())
[task 2023-12-22T12:12:55.664Z] 12:12:55     INFO - Crash dump filename: /tmp/tmp3zk43hix.mozrunner/minidumps/568778a0-d06f-f2e2-4286-5c44fbfe830f.dmp
[task 2023-12-22T12:12:55.664Z] 12:12:55     INFO - Operating system: Linux
[task 2023-12-22T12:12:55.665Z] 12:12:55     INFO -                   4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018
[task 2023-12-22T12:12:55.665Z] 12:12:55     INFO - CPU: amd64
[task 2023-12-22T12:12:55.665Z] 12:12:55     INFO -      family 6 model 85 stepping 7
[task 2023-12-22T12:12:55.665Z] 12:12:55     INFO -      4 CPUs
[task 2023-12-22T12:12:55.665Z] 12:12:55     INFO - Linux Ubuntu 18.04 - bionic (Ubuntu 18.04.6 LTS)
[task 2023-12-22T12:12:55.665Z] 12:12:55     INFO - 
[task 2023-12-22T12:12:55.665Z] 12:12:55     INFO - Crash reason:  SIGSEGV / SEGV_MAPERR
[task 2023-12-22T12:12:55.666Z] 12:12:55     INFO - Crash address: 0x0000000000000000
[task 2023-12-22T12:12:55.666Z] 12:12:55     INFO - Crashing instruction: `mov dword [0x0], 0x164`
[task 2023-12-22T12:12:55.666Z] 12:12:55     INFO - Memory accessed by instruction:
[task 2023-12-22T12:12:55.666Z] 12:12:55     INFO -   0. Address: 0x0000000000000000
[task 2023-12-22T12:12:55.666Z] 12:12:55     INFO -      Size: 4
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO - Process uptime: not available
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO - 
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO - Thread 27 Compositor (crashed)
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO -  0  libxul.so!mozilla::layers::CompositorBridgeParent::StopAndClearResources() [CompositorBridgeParent.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 356 + 0x0]
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO -      rax = 0x00007ff878f58b84    rdx = 0x0000000000000000
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO -      rcx = 0x0000563b04d35588    rbx = 0x00007ff861659eb0
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO -      rsi = 0x00007ff8918ba8b0    rdi = 0x00007ff8918b9680
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO -      rbp = 0x00007ff86bdaf480    rsp = 0x00007ff86bdaf430
[task 2023-12-22T12:12:55.667Z] 12:12:55     INFO -       r8 = 0x00007ff8918ba8b0     r9 = 0x00007ff86bdb0700
[task 2023-12-22T12:12:55.668Z] 12:12:55     INFO -      r10 = 0x0000000000000002    r11 = 0x0000000000000000
[task 2023-12-22T12:12:55.668Z] 12:12:55     INFO -      r12 = 0x0000000000000002    r13 = 0x0000000000000000
[task 2023-12-22T12:12:55.668Z] 12:12:55     INFO -      r14 = 0x0000000000000001    r15 = 0x0000000000000000
[task 2023-12-22T12:12:55.669Z] 12:12:55     INFO -      rip = 0x00007ff87d12e50c
[task 2023-12-22T12:12:55.669Z] 12:12:55     INFO -     Found by: given as instruction pointer in context
[task 2023-12-22T12:12:55.669Z] 12:12:55     INFO -  1  libxul.so!mozilla::layers::CompositorBridgeParent::ActorDestroy(mozilla::ipc::IProtocol::ActorDestroyReason) [CompositorBridgeParent.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 523 + 0x4]
[task 2023-12-22T12:12:55.669Z] 12:12:55     INFO -      rbx = 0x00007ff861659eb0    rbp = 0x00007ff86bdaf4c0
[task 2023-12-22T12:12:55.669Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf490    r12 = 0x0000000000000002
[task 2023-12-22T12:12:55.670Z] 12:12:55     INFO -      r13 = 0x0000000000000000    r14 = 0x0000000000000001
[task 2023-12-22T12:12:55.670Z] 12:12:55     INFO -      r15 = 0x0000000000000000    rip = 0x00007ff87d12f0d7
[task 2023-12-22T12:12:55.670Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.671Z] 12:12:55     INFO -  2  libxul.so!mozilla::ipc::IProtocol::DestroySubtree(mozilla::ipc::IProtocol::ActorDestroyReason) [ProtocolUtils.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 626 + 0xb]
[task 2023-12-22T12:12:55.671Z] 12:12:55     INFO -      rbx = 0x00007ff861659eb0    rbp = 0x00007ff86bdaf510
[task 2023-12-22T12:12:55.671Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf4d0    r12 = 0x0000000000000002
[task 2023-12-22T12:12:55.671Z] 12:12:55     INFO -      r13 = 0x0000000000000000    r14 = 0x0000000000000001
[task 2023-12-22T12:12:55.671Z] 12:12:55     INFO -      r15 = 0x0000000000000000    rip = 0x00007ff87cb10bca
[task 2023-12-22T12:12:55.671Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.672Z] 12:12:55     INFO -  3  libxul.so!mozilla::layers::PCompositorBridgeParent::OnMessageReceived(IPC::Message const&) [PCompositorBridgeParent.cpp: : 659 + 0xc]
[task 2023-12-22T12:12:55.672Z] 12:12:55     INFO -      rbx = 0x00007ff861659eb0    rbp = 0x00007ff86bdaf700
[task 2023-12-22T12:12:55.672Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf520    r12 = 0x00007ff8616cb640
[task 2023-12-22T12:12:55.672Z] 12:12:55     INFO -      r13 = 0x0000000000000000    r14 = 0x00007ff877ecb040
[task 2023-12-22T12:12:55.672Z] 12:12:55     INFO -      r15 = 0x0000000000000000    rip = 0x00007ff87d046b38
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -  4  libxul.so!mozilla::layers::PCompositorManagerParent::OnMessageReceived(IPC::Message const&) [PCompositorManagerParent.cpp: : 202 + 0x8]
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      rbx = 0x00007ff877ecb040    rbp = 0x00007ff86bdaf7f0
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf710    r12 = 0x00007ff8616cb640
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      r13 = 0x0000000000000000    r14 = 0x00007ff85bc36310
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      r15 = 0x0000000000000001    rip = 0x00007ff87d051721
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -  5  libxul.so!mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [MessageChannel.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 1813 + 0x8]
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      rbx = 0x00007ff85bc36310    rbp = 0x00007ff86bdaf860
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf800    r12 = 0x00007ff877e4f460
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      r13 = 0x0000000000000000    r14 = 0x00007ff877ecb0c8
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -      r15 = 0x0000000000000001    rip = 0x00007ff87cafea0f
[task 2023-12-22T12:12:55.673Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -  6  libxul.so!mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >) [MessageChannel.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 1732 + 0xa]
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      rbx = 0x00007ff877ecb0c8    rbp = 0x00007ff86bdaf950
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf870    r12 = 0x00007ff86bdaf960
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      r13 = 0x00007ff8685e2160    r14 = 0x00007ff877e4f460
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      r15 = 0x0000000000000000    rip = 0x00007ff87cafc6b1
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -  7  libxul.so!mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) [MessageChannel.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 1525 + 0xa]
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      rbx = 0x00007ff877ecb0c8    rbp = 0x00007ff86bdaf9b0
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf960    r12 = 0x00007ff85bc36310
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      r13 = 0xaaaaaaaaaaaaaaaa    r14 = 0x00007ff877e4f460
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -      r15 = 0x00007ff85c8b2970    rip = 0x00007ff87cafcf3e
[task 2023-12-22T12:12:55.674Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -  8  libxul.so!mozilla::ipc::MessageChannel::MessageTask::Run() [MessageChannel.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 1623 + 0xa]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rbx = 0x00007ff8685e2160    rbp = 0x00007ff86bdaf9f0
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaf9c0    r12 = 0x0000033a47d2ed14
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r13 = 0xaaaaaaaaaaaaaaaa    r14 = 0x00007ff85c8b2970
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r15 = 0x00007ff8685e2160    rip = 0x00007ff87cafdad0
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -  9  libxul.so!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 1193 + 0x5]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rbx = 0x00007ff86f35b900    rbp = 0x00007ff86bdafad0
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafa00    r12 = 0x0000033a47d2ed14
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r13 = 0xaaaaaaaaaaaaaaaa    r14 = 0x0000000000000000
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r15 = 0x00000000ffffffff    rip = 0x00007ff87c112a28
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO - 10  libxul.so!NS_ProcessNextEvent(nsIThread*, bool) [nsThreadUtils.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 480 + 0xf]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rbx = 0x0000000000000001    rbp = 0x00007ff86bdafb00
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafae0    r12 = 0x0000000000000000
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r13 = 0x00007ff86f377060    r14 = 0x00007ff86bdafbb0
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r15 = 0x00007ff86f35b900    rip = 0x00007ff87c11952e
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO - 11  libxul.so!mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [MessagePump.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 330 + 0xc]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rbx = 0x00007ff86f377040    rbp = 0x00007ff86bdafb50
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafb10    r12 = 0x0000000000000000
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r13 = 0x00007ff86f377060    r14 = 0x00007ff86bdafbb0
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r15 = 0x00007ff86f35b900    rip = 0x00007ff87cb0374c
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO - 12  libxul.so!MessageLoop::RunHandler() [message_loop.cc:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 363]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: inlining
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO - 13  libxul.so!MessageLoop::Run() [message_loop.cc:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 345 + 0x4]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rbx = 0x00007ff86f357380    rbp = 0x00007ff86bdafb80
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafb60    r12 = 0x00007ff86f357388
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r13 = 0x0000000000000002    r14 = 0x000000000000000a
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r15 = 0x00007ff86bdafbb0    rip = 0x00007ff87ca80412
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO - 14  libxul.so!nsThread::ThreadFunc(void*) [nsThread.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 370 + 0x7]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rbx = 0x00007ff86f357380    rbp = 0x00007ff86bdafdb0
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafb90    r12 = 0x00007ff86f357388
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r13 = 0x0000000000000002    r14 = 0x000000000000000a
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r15 = 0x00007ff86bdafbb0    rip = 0x00007ff87c10df44
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO - 15  libnspr4.so!_pt_root [ptthread.c:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 201 + 0x6]
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rbx = 0x00007ff86f30ea60    rbp = 0x00007ff86bdafe00
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafdc0    r12 = 0x00007ff86bdb0630
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r13 = 0x0000000000000002    r14 = 0x00007ff89121df80
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -      r15 = 0x00007ff86bdb0700    rip = 0x00007ff89281a720
[task 2023-12-22T12:12:55.675Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO - 16  firefox-bin!set_alt_signal_stack_and_start(PthreadCreateParams*) [pthread_create_interposer.cpp:826eca1b1c545a3d8fd5a55cc61fbfaf81fa173f : 81 + 0x5]
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      rbx = 0x00007ff86f30ea60    rbp = 0x00007ff86bdafeb0
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafe10    r12 = 0x00007ff86bdaff80
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      r13 = 0x0000000000000000    r14 = 0x00007ff86bdafe20
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      r15 = 0x00007ff89281a590    rip = 0x0000563b04c8a3dd
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO - 17  libpthread.so.0 + 0x76da
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      rbx = 0x0000000000000000    rbp = 0x0000000000000000
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      rsp = 0x00007ff86bdafec0    r12 = 0x00007ff86bdaff80
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      r13 = 0x0000000000000000    r14 = 0x00007ff86f319740
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      r15 = 0x00007fff819f7280    rip = 0x00007ff8924086db
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -     Found by: call frame info
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO - 18  libc.so.6 + 0x121a3e
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -      rsp = 0x00007ff86bdaff80    rip = 0x00007ff8915eea3f
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO -     Found by: stack scanning
[task 2023-12-22T12:12:55.676Z] 12:12:55     INFO - 
Component: Marionette → Graphics
Product: Remote Protocol → Core
Attachment #9385857 - Attachment is obsolete: true
Crash Signature: [@ mozilla::layers::CompositorBridgeParent::StopAndClearResources]

Sotaro, is the assertion here correct?

Flags: needinfo?(sotaro.ikeda.g)

Bug 1884531 is another signature for this crash.

See Also: → 1884531

Seems like this might be fixable by moving this nullptr set after the thread shutdown itself. I'll post a patch that does that.

Assignee: nobody → bwerth

(In reply to Brad Werth [:bradwerth] from comment #41)

Seems like this might be fixable by moving this nullptr set after the thread shutdown itself. I'll post a patch that does that.

Or something to fixup the lifecycle. Because it seems like sCompositorThreadHolder needs to be non-NULL during ActorDestroy() in order to make this assert work.

Is is important that sCompositorThreadHolder remains non-null while
the compositor thread is executing tasks. Anything that checks
IsInCompositorThread() will fail if it is null. This change moves the
setting of the signal bool into the dispatched method itself, instead of
relying on the destructor.

Attachment #9423051 - Attachment description: WIP: Bug 1871557: Explicitly signal compositor shutdown instead of relying on destructor. → Bug 1871557: Explicitly signal compositor shutdown instead of relying on destructor.
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/227a47dd111c Explicitly signal compositor shutdown instead of relying on destructor. r=gfx-reviewers,nical

Hmmm, frustrating. I can't figure out from the test failure how to run a local xpcshell test that replicates the failure. I can see that test_child_assertions.js is implicated, but that file seems to be written just-in-time and so I'm not sure how to invoke it with a ./mach xpcshell-test command. I'll run everything locallly (time-consuming!) and see if there's a specific test file that fails.

(In reply to Jeff Muizelaar [:jrmuizel] from comment #39)

Sotaro, is the assertion here correct?

It seemed that there were cases that CompositorBridgeParent::StopAndClearResources() is called after "sCompositorThreadHolder = nullptr" in CompositorThreadHolder::Shutdown().

That is addressed by D221268.

Flags: needinfo?(sotaro.ikeda.g)
Attachment #9423051 - Attachment is obsolete: true

As described in CompositorThreadHolder::Shutdown, it doesn't actually
shutdown the compositor thread, and other work may still be running on
it. Without this change, after calling Shutdown, IsInCompositorThread
will return false even for code running on the compositor thread. This
change adds an extra check that will return true if the current thread
matches the thread id of the compositor thread, even if the holder no
longer exists.

Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0c625ea7986 Make CompositorThreadHolder::IsInCompositorThread more accurate. r=gfx-reviewers,aosmond
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch

The patch landed in nightly and beta is affected.
:bradwerth, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(bwerth)

This can ride the trains, since it's just a fix for testing intermittents.

Flags: needinfo?(bwerth)

We're still seeing these on ESR128. Can we uplift this fix there assuming there's no downside to doing so? Thanks!

Flags: needinfo?(bwerth)

Comment on attachment 9424005 [details]
Bug 1871557: Make CompositorThreadHolder::IsInCompositorThread more accurate.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Prevents some shutdown crashes in debug builds.
  • User impact if declined: Test runs may have spurious asserts.
  • Fix Landed on Version: 132
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes one line calculating a different boolean condition. Should graft cleanly.
Flags: needinfo?(bwerth)
Attachment #9424005 - Flags: approval-mozilla-esr128?

Comment on attachment 9424005 [details]
Bug 1871557: Make CompositorThreadHolder::IsInCompositorThread more accurate.

Approved for 128.4esr.

Attachment #9424005 - Flags: approval-mozilla-esr128? → approval-mozilla-esr128+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: