Closed Bug 1871578 Opened 2 years ago Closed 9 months ago

Intermittent gfx/tests/reftest/1845828-1.html == gfx/tests/reftest/1845828-1-ref.html | single tracking bug

Categories

(Core :: Graphics, defect)

defect

Tracking

()

RESOLVED INCOMPLETE
Tracking Status
firefox137 --- fixed

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [stockwell disabled])

Attachments

(3 files, 2 obsolete files)

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Attachment #9385538 - Attachment is obsolete: true
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

@Nicolas, with the landing of bug 1924152 & bug 1918138, this reftest has turned high frequent
Confirmed with backfills and retriggers
Here is a recent failure log

Could you take a look?

Flags: needinfo?(nical.bugzilla)
Keywords: regression
Regressed by: 1924152, 1918138
Summary: Intermittent gfx/tests/reftest/1845828-1.html == gfx/tests/reftest/1845828-1-ref.html | single tracking bug → High frequent gfx/tests/reftest/1845828-1.html == gfx/tests/reftest/1845828-1-ref.html | single tracking bug

Hello @Nicolas, are there any updates on this?

See Also: → 1941951

111 total failures in the last 30 days, this turned into asan only since the beginning of the month after Migration Win11 reftest from 22H2 -> 24H2 https://hg.mozilla.org/integration/autoland/rev/11b9aa4a5f44cd406be273f59f1682517e21a8c6 : https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2025-01-23&endday=2025-02-22&tree=trunk&failurehash=all&bug=1871578

Flags: needinfo?(nical.bugzilla)
Summary: High frequent gfx/tests/reftest/1845828-1.html == gfx/tests/reftest/1845828-1-ref.html | single tracking bug → Frequent asan gfx/tests/reftest/1845828-1.html == gfx/tests/reftest/1845828-1-ref.html | single tracking bug
Flags: needinfo?(nical.bugzilla)
Flags: needinfo?(jmaher)

yes, that condition would work!

Flags: needinfo?(jmaher)
Assignee: nobody → smolnar
Assignee: smolnar → nobody
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2960fc28a612 Disable '1845828-1.html' on win asan for frequent failures. r=jmaher DONTBUILD
Summary: Frequent asan gfx/tests/reftest/1845828-1.html == gfx/tests/reftest/1845828-1-ref.html | single tracking bug → Intermittent gfx/tests/reftest/1845828-1.html == gfx/tests/reftest/1845828-1-ref.html | single tracking bug

Back these two patches out from beta because of a regression.

Attachment #9469097 - Flags: approval-mozilla-beta?
Attachment #9469097 - Flags: approval-mozilla-release?

Comment on attachment 9469097 [details]
Bug 1871578 - Backed out changesets 48aaa9a98d33 and 656bdcc5d6b0

Moved the target repo from beta to release.
136 is now in release https://whattrainisitnow.com/release/?version=136

Attachment #9469097 - Flags: approval-mozilla-beta?
Flags: needinfo?(nical.bugzilla)
See Also: → 1947113
Duplicate of this bug: 1947113
See Also: → 1947259

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

:bhood, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.

Flags: needinfo?(bhood)
Severity: S4 → S3
Flags: needinfo?(bhood)
Depends on: 1952863

Comment on attachment 9468925 [details]
Bug 1871578 - Ensure non-requested frames go through the normal present path. r=#gfx-reviewers

Revision D239904 was moved to bug 1952863. Setting attachment 9468925 [details] to obsolete.

Attachment #9468925 - Attachment is obsolete: true
Attachment #9469097 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9469097 - Attachment description: WIP: Bug 1871578 - Backed out changesets 48aaa9a98d33 and 656bdcc5d6b0 → Bug 1871578 - Backed out changesets 48aaa9a98d33 and 656bdcc5d6b0

The patches that caused the regression have not been backed out of beta yet, is that OK?

Flags: needinfo?(nical.bugzilla)

Comment on attachment 9469097 [details]
Bug 1871578 - Backed out changesets 48aaa9a98d33 and 656bdcc5d6b0

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Flickering issues
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): We already backed this out from release.
  • String changes made/needed: None.
  • Is Android affected?: Yes
Flags: needinfo?(nical.bugzilla)
Attachment #9469097 - Flags: approval-mozilla-beta?

(In reply to 6k64x4ma from comment #33)

The patches that caused the regression have not been backed out of beta yet, is that OK?

Thanks for pointing it out. I would like this backed out from beta as well. Nightly has a proper fix.

Comment on attachment 9469097 [details]
Bug 1871578 - Backed out changesets 48aaa9a98d33 and 656bdcc5d6b0

These patches don't graft cleanly to the 137 beta branch.
If the fix is the one in bug 1952863, it grafts cleanly to beta.

Flags: needinfo?(nical.bugzilla)
Attachment #9469097 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9474044 - Flags: approval-mozilla-beta?

Thanks Pascal. I submitted a new version of the backout that applies cleanly on beta 137. Thankfully the conflict was only on a white space change so it should still be less risky than uplifting the nightly fix.

Flags: needinfo?(nical.bugzilla)

Comment on attachment 9474044 [details]
Bug 1871578 - Backed out changesets 48aaa9a98d33 and 656bdcc5d6b0 from 137. r=pascalc

Approved for the beta branch before building our release candidate

Attachment #9474044 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: REOPENED → RESOLVED
Closed: 1 year ago9 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: