1871612 - Non-native theme tooltips appear out-of-place on macOS

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Sam Johnson]

After bug 1696988, the non-native theme can draw tooltips on macOS in some scenarios such as about:preferences. The non-native theme draws a rounded rectangle with a border that is the same color as the text, which looks pretty out-of-place on macOS--tooltips on macOS do not have rounded corners, and the border is subtle compared to the text color.

However, after bug 1871507, the window server will be drawing both the correct background and border for the tooltip already. The non-native theme no longer needs to draw any background or border for tooltips on macOS.

Comment 1

[Sam Johnson]

Attachment: Bug 1871612 - Improve non-native theme tooltips on macOS. r?emilio

After bug 1696988, the non-native theme can draw tooltips on macOS in some scenarios such as about:preferences. The non-native theme draws a rounded rectangle with a border that is the same color as the text, which looks pretty out-of-place on macOS--tooltips on macOS do not have rounded corners, and the border is subtle compared to the text color.

However, after bug 1871507, the window server will be drawing both the correct background and border for the tooltip already. The non-native theme no longer needs to draw any background or border for tooltips on macOS.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a82f2a340b4
Improve non-native theme tooltips on macOS. r=emilio

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3a82f2a340b4