1871639 - Performance inefficiencies (COPY_INSTEAD_OF_MOVE) in netwerk/dns/NativeDNSResolverOverrideParent.cpp

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

** CID 1559863:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/netwerk/dns/NativeDNSResolverOverrideParent.cpp: 67 in mozilla::net::NativeDNSResolverOverrideParent::AddHTTPSRecordOverride(const nsTSubstring<char> &, const unsigned char *, unsigned int)()


________________________________________________________________________________________________________
*** CID 1559863:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/netwerk/dns/NativeDNSResolverOverrideParent.cpp: 67 in mozilla::net::NativeDNSResolverOverrideParent::AddHTTPSRecordOverride(const nsTSubstring<char> &, const unsigned char *, unsigned int)()
61     }
62     
63     NS_IMETHODIMP NativeDNSResolverOverrideParent::AddHTTPSRecordOverride(
64         const nsACString& aHost, const uint8_t* aData, uint32_t aLength) {
65       nsCString host(aHost);
66       CopyableTArray<uint8_t> data(aData, aLength);
>>>     CID 1559863:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "host" is copied in call to copy constructor "nsTString<char>", when it could be moved instead.
67       auto task = [self = RefPtr{this}, host, data = std::move(data)]() {
68         Unused << self->SendAddHTTPSRecordOverride(host, data);
69       };
70       gIOService->CallOrWaitForSocketProcess(std::move(task));
71       return NS_OK;
72     }

Comment 1

[Jishnu M Thampan [:thampan]]

Hi, Could you please assign this issue to me? Thanks!

Comment 2

[Jishnu M Thampan [:thampan]]

Attachment: Bug 1871639 - Performance inefficiencies (COPY_INSTEAD_OF_MOVE) in netwerk/dns/NativeDNSResolverOverrideParent.cpp. r=#necko

Comment 3

[Jishnu M Thampan [:thampan]]

If the changes are fine, could you please help in landing the patch?

Comment 4

[Valentin Gosu [:valentin]]

Queued for landing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c009c361b3f
https://hg.mozilla.org/integration/autoland/rev/bd1fd234a81c
Performance inefficiencies (COPY_INSTEAD_OF_MOVE) in netwerk/dns/NativeDNSResolverOverrideParent.cpp. r=necko-reviewers,valentin

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bd1fd234a81c

Comment 7

[Jishnu M Thampan [:thampan]]

Thanks for landing!