1871735 - GTK_PATH=/app/lib/gtkmodules should be dropped from Firefox flatpak manifest

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[bbhtt]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

This was added because cups was missing from the runtime and came through the Firefox baseapp on Flathub

The baseapp dropped cups because it was added to the runtime in 22.08 https://github.com/flathub/org.mozilla.firefox.BaseApp/commit/075e501a04430e82698c20bf58a6e029d48323aa

Comment 1

[bbhtt]

Attachment: Bug 1871735 - Drop GTK_PATH=/app/lib/gtkmodules. r?emilio

This was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1712555
because was CUPS was missing from the runtime back then and was added to
the Firefox baseapp on Flathub.

Since then CUPS was added to the runtime in 22.08 and the baseapp dropped
CUPS https://github.com/flathub/org.mozilla.firefox.BaseApp/commit/075e501a04430e82698c20bf58a6e029d48323aa

The directory no longer exists in the Flatpak package

Comment 2

[bbhtt]

To check: flatpak run --command=sh org.mozilla.firefox -c "ls -lA /app/lib"

Comment 3

[bbhtt]

Hi, can you please land this? I don't have access. Thanks.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Thanks, done, sorry for not noticing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/459f9b5f0793
Drop GTK_PATH=/app/lib/gtkmodules. r=emilio

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/459f9b5f0793