1871809 - Importing from Chrome imported into both Bookmarks Toolbar and Bookmarks Menu

Status: RESOLVED INCOMPLETE

(Firefox :: Migration, defect)

Description

[Jakub T. Jankiewicz]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

I've imported bookmarks and everything else including history from Google Chrome. I decided to switch in the upcoming removing v2 manifest that will make uBlock don't work.

I added a bookmark to a directory or created a new directory.

Actual results:

The bookmark and directory are not visible when using bookmarks. It's only visible in the Manage Bookmarks tool.

Expected results:

I should have links and directories in the place where I put it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mark Banner (:standard8)]

(In reply to Jakub T. Jankiewicz from comment #0)

Actual results:

The bookmark and directory are not visible when using bookmarks. It's only visible in the Manage Bookmarks tool.

Can you add a screenshot to help explain this please? Which bit of the UI do you mean for "when using bookmarks"?

Comment 3

[Jakub T. Jankiewicz]

Attachment: Mising bookmark

Here is a recording of missing bookmarks, they appear in the manager but missing in a directory. The same happens if I add a new directory.

Comment 4

[Mark Banner (:standard8)]

From the recording, I can see that the search folder where you are saving the bookmark is in the Bookmarks Menu. This is under a different location to the bookmarks toolbar which is where you are looking for the bookmark.

Comment 5

[Jakub T. Jankiewicz]

Ok, then why did Firefox create two copies of my bookmarks? In Chrome I have only one search directory why on Firefox are there two independent copies? What is the Bookmark menu and Bookmark toolbar, why is there no one bookmarks like in Chrome?

Comment 6

[Jakub T. Jankiewicz]

And if this it's by design how to delete one and only keep the one in the toolbar?

Comment 7

[Mark Banner (:standard8)]

(In reply to Jakub T. Jankiewicz from comment #5)

Ok, then why did Firefox create two copies of my bookmarks? In Chrome I have only one search directory why on Firefox are there two independent copies?

I don't know off hand, but I would guess that to be a migration issue. I'll move this across to the migration component for further discussion.

What is the Bookmark menu and Bookmark toolbar, why is there no one bookmarks like in Chrome?
And if this it's by design how to delete one and only keep the one in the toolbar?

The bookmarks menu is in the bar at the top of the screen. The toolbar is the one above the web page content.

Firefox has always had multiple top-level folders, some people prefer having different access points. It is not currently possible to delete the top-level folders, but changing how the top-level folders work is something we've had as a desire for a while, but it has not had priority. There are existing bugs on this, one example is bug 1801130.

Comment 8

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/24ea2579c4a94d5da8db4bb529cbefe5e5e3c2d3/browser/components/migration/ChromeProfileMigrator.sys.mjs#730,745,760

See code above - chrome bookmark import only creates bookmarks in 2 places: the bookmarks toolbar, and the "other bookmarks" folder. (This is because Chrome does in fact also have more than 1 place for bookmarks, the bookmarks bar and "Other bookmarks", which in the star popup in chrome is simply called "All bookmarks". No, I don't know why there are 2 different names...)

I don't know why there are copies in your bookmarks menu, but I don't think the migration itself put them there. I just tried myself, and also cannot reproduce.

If you create a blank Firefox profile for testing and re-import from chrome, do the duplicate bookmarks appear in the bookmarks menu there, too?

Comment 9

[Jakub T. Jankiewicz]

I just checked the other bookmarks in Chrome and it's empty. Will try to create new profile.

Comment 10

[Jakub T. Jankiewicz]

How to create a new profile? Do I need to logout to create a new profile?

Comment 11

[:Gijs (he/him)]

(In reply to Jakub T. Jankiewicz from comment #10)

How to create a new profile? Do I need to logout to create a new profile?

No, you can use the instructions at https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles - tl;dr you can start firefox with firefox -no-remote -p and then create a profile and run with it.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Hi Jakub,

Any updates here? Any success creating a new profile?

Comment 13

[Jakub T. Jankiewicz]

Yes, sorry. I just created a new profile and after import, I only have the Toolbar (with all bookmarks) and the Menu only has recent tags.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Hm. I'm at a bit of a loss to explain this. Jakub, it sounds like with a new profile, when you did the migration, the bookmarks ended up in one place, instead of copied.

Unless we can get some repeatable steps-to-reproduce here, I'm afraid this bug is not actionable. :/ I'm going to close this one as INCOMPLETE unless we find some repeatable steps-to-reproduce.

Comment 15

[Jakub T. Jankiewicz]

I would close it as not a bug. I'm not sure why I ended up with two bookmark copies. I don't think I will be able to reproduce.