1871992 - Removing a threaded message in a unified folder may result in incorrect levels in the thread

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

There is a rather obvious bug in nsMsgXFViewThread::RemoveChildHdr that affects the correct adjustment of child header levels of the removed header.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1871992 - Fix bug in nsMsgXFViewThread::RemoveChildHdr. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29aa9bd66ae8
Fix bug in nsMsgXFViewThread::RemoveChildHdr. r=mkmelin

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9370284 [details]
Bug 1871992 - Fix bug in nsMsgXFViewThread::RemoveChildHdr. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Apparently this little bug has been around since 2008.
User impact if declined: Children of a removed message in an xf view may be re-indented incorrectly.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9370284 [details]
Bug 1871992 - Fix bug in nsMsgXFViewThread::RemoveChildHdr. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 122.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/92c09d637ca4

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9370284 [details]
Bug 1871992 - Fix bug in nsMsgXFViewThread::RemoveChildHdr. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: Children of a removed message in an xf view may be re-indented incorrectly.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9370284 [details]
Bug 1871992 - Fix bug in nsMsgXFViewThread::RemoveChildHdr. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.8.1:
https://hg.mozilla.org/releases/comm-esr115/rev/1571e3f3c2ed