187209 - role for toplevel should be "frame"

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Bolian Yin]

Comment 1

[Kyle Yuan]

mass changing QA contact to Jessie Li.

Comment 2

[Simford]

Attachment: patch

change the role of Application-Level and TopLevel

Comment 3

[Bolian Yin]

You can simplified this block
+    //the cross-platform Accessible object return the same value for
+    //both "ATK_ROLE_MENU_ITEM" and "ATK_ROLE_MENU"
+    if (accRole == ATK_ROLE_MENU_ITEM) {
+        gint count = 0;
+        mAccessible->GetAccChildCount(&count);
+        if (count > 0)  //it should be a popup menu
+            accRole = ATK_ROLE_MENU;
+    }
to:
if ((accRole == ATK_ROLE_MENU_ITEM) && GetChildCount())
    accRole = ATK_ROLE_MENU;

Comment 4

[Simford]

Attachment: new patch due to comment #3

Comment 5

[Bolian Yin]

Comment on attachment 110927 [details] [diff] [review]
new patch due to comment #3

looks good to me

Comment 6

[Bolian Yin]

checked in Trunk. Thanks, Simford.

Comment 7

[hacker formerly known as [e-mail]]

This checkin broke the gtk2 tinderbox.
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/1042021140.2765.gz&fulltext=1

Comment 8

[Bolian Yin]

It is caused by using a newer version of atk (atk-1.1.x), we need other way to
define ATK_ROLE_APPLICATION.
Simford will paste a new patch soon.

Comment 9

[Simford]

Attachment: new patch

added new globlal Contant Value

Comment 10

[Bolian Yin]

I think we can match the role constant like:

ROLE_APPLICATION ->  ATK_ROLE_APPLICATION
ROLE_PANE (for toplevel window) -> ATK_ROLE_FRAME
ROLE_PANE  (for dialog)  -> ATK_ROLE_DIALOG
ROLE_PANE (for others) ->  ATK_ROLE_PANEL

Comment 11

[Simford]

Attachment: patch

new patch due to comment #10

Comment 12

[Simford]

Attachment: patch

new patch after some modifications

Comment 13

[Simford]

Attachment: patch-06

change comments

Comment 14

[Bolian Yin]

Comment on attachment 111137 [details] [diff] [review]
patch-06

I think it is good enough now.

Comment 15

[Bolian Yin]

checked in trunk. Thanks.