1872560 - Perma browser_history_firefoxview_next.js | Uncaught exception in test bound test_list_ordering - at PlacesUtils.sys.mjs:781 - Error: PageInfo: Invalid value for property 'visits': [{"date":"2024-12-01T00:09:58.096Z"}]

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=441823558&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/W0ibIUm4QaGvbgjTDEG1sQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-01-01T00:09:58.251Z] 00:09:58     INFO - 
[task 2024-01-01T00:09:58.251Z] 00:09:58     INFO - Console message: [JavaScript Error: "Error: No DOM node set for aPlacesNode.
[task 2024-01-01T00:09:58.251Z] 00:09:58     INFO - node.type: 0. node.parent: [xpconnect wrapped nsINavHistoryResultNode]" {file: "chrome://browser/content/places/browserPlacesViews.js" line: 116}]
[task 2024-01-01T00:09:58.251Z] 00:09:58     INFO - _getDOMNodeForPlacesNode@chrome://browser/content/places/browserPlacesViews.js:116:13
[task 2024-01-01T00:09:58.251Z] 00:09:58     INFO - nodeTitleChanged@chrome://browser/content/places/browserPlacesViews.js:499:20
[task 2024-01-01T00:09:58.251Z] 00:09:58     INFO - 
[task 2024-01-01T00:09:58.252Z] 00:09:58     INFO - Buffered messages finished
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/firefoxview-next/browser_history_firefoxview_next.js | Uncaught exception in test bound test_list_ordering - at resource://gre/modules/PlacesUtils.sys.mjs:781 - Error: PageInfo: Invalid value for property 'visits': [{"date":"2024-12-01T00:09:58.096Z"}]
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - Stack trace:
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - validateItemProperties@resource://gre/modules/PlacesUtils.sys.mjs:781:19
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - validatePageInfo@resource://gre/modules/PlacesUtils.sys.mjs:1174:17
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - insert@resource://gre/modules/History.sys.mjs:252:33
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - addHistoryItems@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/firefoxview-next/browser_history_firefoxview_next.js:125:29
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - test_list_ordering@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/firefoxview-next/browser_history_firefoxview_next.js:167:9
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1138:26
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1127:14
[task 2024-01-01T00:09:58.253Z] 00:09:58     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-01-01T00:09:58.254Z] 00:09:58     INFO - Leaving test bound test_list_ordering
[task 2024-01-01T00:09:58.254Z] 00:09:58     INFO - Entering test bound test_empty_states
[task 2024-01-01T00:09:58.255Z] 00:09:58     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/firefoxview-next/browser_history_firefoxview_next.js | Firefox View tab exists - [object XULElement] == true - 

Comment 1

[Cristian Tuns]

Attachment: Bug 1872560 - Disable browser_history_firefoxview_next.js on all platforms. r=aryx

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc2c444bd65a
Disable browser_history_firefoxview_next.js on all platforms.

Comment 3

[Intermittent Failures Robot]

20 failures in 1162 pushes (0.017 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 16
• mozilla-central: 4

Platform and build breakdown:

• windows11-64-2009-shippable-qr: 14
  • opt: 14
• macosx1015-64-shippable-qr: 2
  • opt: 2
• macosx1100-64-shippable-qr: 3
  • opt: 3
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1872560&startday=2023-12-25&endday=2023-12-31&tree=all

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/221b482595d9

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cc2c444bd65a2dec4d9c7511a8b3826f31f8158e

Comment 6

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1872560 - Fix calculation of date one month ago when current date is in January causing perma test failures r=jsudiaman

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f754a301fc56
Fix calculation of date one month ago when current date is in January causing perma test failures r=jsudiaman,fxview-reviewers

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1207c264b863

Comment 9

[Norisz Fay [:noriszfay]]

After f754a301fc56 landed, there's this perma failure present as seen from the retriggers & backfills. Here is the failure log.

Comment 10

[Kelly Cochrane [:kcochrane]]

Ah looks like this fail-if was added prematurely when I rebased off autoland. Can we reopen this revision so I can remove that?

Comment 11

[Kelly Cochrane [:kcochrane]]

Or should I submit a new patch to remove that?

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If the phabricator revision shall be reused, the patch should be backed out. Else a new phabricator revision should be created.

Comment 13

[Kelly Cochrane [:kcochrane]]

I'll create a new patch to resolve if that works.

Comment 14

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1872560 - Remove fail-if condition for Fx View history test r=jsudiaman

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc67c788cded
Remove fail-if condition for Fx View history test r=jsudiaman,fxview-reviewers

Comment 16

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f754a301fc56
https://hg.mozilla.org/mozilla-central/rev/cc67c788cded

Comment 17

[Cosmin Sabou [:CosminS]]

I think 121 might also be affected by this new year failure but since there was no push there since the 30th I cannot confirm that, esr115 is unaffected.
Donal, if you want to re-enable the test on beta there's comment 16.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/710adac8d0b6
https://hg.mozilla.org/releases/mozilla-beta/rev/fba35a43e21b

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/e914f99298a8

Comment 20

[Intermittent Failures Robot]

4 failures in 2274 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2
• autoland: 2

Platform and build breakdown:

• windows10-64-2009-qr: 1
  • debug: 1
• windows10-64-2009-shippable-qr: 1
  • opt: 1
• linux1804-64-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1872560&startday=2024-01-01&endday=2024-01-07&tree=all