1872703 - AC Add Error Support Connection to API Calls

Status: RESOLVED FIXED

(Firefox for Android :: Translations, enhancement, P2)

Description

[Olivia Hall [:olivia]]

This bug is to build on bug 1862263 to intercept the error as it exits GeckoView and ensure a TranslationError throwable is called. For example, a translation API call such as this one, should be intercepted to map to a TranslationError to ensure we do not cross the Gecko abstraction layer elsewhere when handling errors.

More background in this conversation.

Comment 1

[Olivia Hall [:olivia]]

Should also use this bug to adjust the utility function (fromGeckoErrorToTranslationError) for mapping to something to fit in with the Kotlin paradigm:

fun TranslationsException.intoTranslationError(): TranslationError {
  return when (code) {
    // ...
  }
}

See this discussion for more details on what to adjust.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1872703 - Named Translation Errors (#5028)

Comment 3

[BMO Github Automation]

Authored by https://github.com/ohall-m
https://github.com/mozilla-mobile/firefox-android/commit/48c24fc63985ef1edb467b46f8617f815d08a452
[main] Bug 1872703 - Named Translation Errors