1872891 - [comm-central] perma gmake[4]: *** [Makefile:38: vendored-rust-check] Error 1

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: alessandro [at] thunderbird.net
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=442045409&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/E2xa8lEOToKI92UnBW5dgQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

Is there a point having them enabled, but perma busted? Why not disable until the builds are normally green?

Comment 2

[Daniel Darnell [:dandarnell]]

It appears that rust dependencies need to be refreshed. I'm working on a patch now.

Comment 3

[Rob Lemley [:rjl]]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Is there a point having them enabled, but perma busted? Why not disable until the builds are normally green?

Sort of...

Part of this is to see just how often we end up perma-busted, and then to test our tooling for effectiveness.

Running ./mach tb-rust vendor should fix the bustage. At least until m-c updates Rust dependencies again.

This really could have been done in the ash repo.

The path towards automation: A try job checks for deps out of sync and runs tb-rust vendor if needed. It can submit a patch to Phabricator (hopefully) and ping #thunderbird-ci.

This looks like:

$ mach tb-rust check-upstream
Rust dependencies are out of sync. Run `mach tb-vendor`.

Cargo.lock

Followed by a Python import error... I'll fix that.

$ mach tb-rust vendor
[ lots of output ]
$ diff -qr ../third_party/rust third_party/rust
Only in ../third_party/rust: autocfg
Only in ../third_party/rust: mio-0.6.23
Only in ../third_party/rust: rure
Only in ../third_party/rust: .sources
[ this looks correct ]
$ mach tb-rust check-upstream
Rust dependencies are okay.

Make sure to hg addremove . and commit, and include m-c hash in the commit message for reproducibility purposes.

Comment 4

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1872891 - Update Rust dependencies (mozilla-central: a32652cce394). r=#thunderbird-build-system-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e7d81463de9f
Update Rust dependencies (mozilla-central: a32652cce394). r=rjl

Comment 6

[Intermittent Failures Robot]

5 failures in 2274 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform and build breakdown:

• linux64: 2
  • opt: 2
• osx-cross: 2
  • opt: 2
• windows2012-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1872891&startday=2024-01-01&endday=2024-01-07&tree=all

Comment 7

[Rob Lemley [:rjl]]

For the moment, these will happen. To fix, run the steps in comment 3.

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1872891 - Sync Rust code with mozilla-central. r=#thunderbird-reviewers

m-c: 750c44842f26

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/150dd9e76b0c
Sync Rust code with mozilla-central. r=john.bieling

Comment 10

[Ikey Doherty]

Attachment: Bug 1872891 - Update Rust dependencies (mozilla-central: 16becc119397). r=#thunderbird-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e958d43fcaa2
Update Rust dependencies (mozilla-central: 16becc119397). r=thunderbird-reviewers,babolivier

Comment 12

[Ikey Doherty]

Attachment: Bug 1872891: Update Rust dependencies (mozilla-central: f593f07c9772). r=#thunderbird-reviewers

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d3fb50d2fa63
Update Rust dependencies (mozilla-central: f593f07c9772). r=babolivier DONTBUILD

Comment 14

[Daniel Darnell [:dandarnell]]

Ever since bug 1869860 (and subsequent related bugs), this bug is no longer relevant, since Rust third-party vendoring is (semi-)automatic.