1872935 - Reconcile original categorization ping patches with updated code

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Stephanie Cunnane [:scunnane]]

Some of the changes introduced in the 2 patches for bug 1854692 are still applicable to the current implementation and need to be re-incorporated into the code.

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1872935 - Reconcile original categorization ping patches with updated code. r?jteow!

Depends on D196217

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:scunnane, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Stephanie Cunnane [:scunnane]]

This code is ready to land from the perspective of the search team, but we are awaiting the Glean OHTTP implementation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38df2dd9c60
Reconcile original categorization ping patches with updated code. r=jteow

Comment 5

[Cristian Tuns]

Backed out for causing bc failures in browser_search_glean_serp_event_telemetry_categorization_enabled_by_nimbus_variable.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/telemetry/browser_search_glean_serp_event_telemetry_categorization_enabled_by_nimbus_variable.js | Uncaught exception in test bound test_enable_experiment_when_pref_is_not_enabled - at chrome://mochitests/content/browser/browser/components/search/test/browser/telemetry/head.js:420 - TypeError: can't access property "testGetValue", Glean.serp.categorization is undefined

Also Mn failures: https://treeherder.mozilla.org/logviewer?job_id=451549277&repo=autoland

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc969033195f
Reconcile original categorization ping patches with updated code. r=jteow

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset bc969033195f (Bug 1872935) for causing failures in test_ping_submitted.py

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=ctmZHyJlSKaTRlhN2nnX4g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=bc969033195f48d3d2f3b04239fe6379a5620af4

Log: https://treeherder.mozilla.org/logviewer?job_id=451570471&repo=autoland&lineNumber=14616

Backout: https://hg.mozilla.org/integration/autoland/rev/7cd57b786487d0c0e20eca619adc14778c9203f5

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/274d0d96881c
Reconcile original categorization ping patches with updated code. r=jteow,firefox-desktop-core-reviewers

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/274d0d96881c