1872959 - [wpt-sync] Sync PR 43848 - Fix Highlight Pseudos using container-relative units

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43848 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43848
Details from upstream follow.

Stephen Chenney <[e-mail]> wrote:

Fix Highlight Pseudos using container-relative units

Add support for creating a new style when the highlight uses container-relative units and has a different container to that of its parent.

Add testing of highlights using container queries.

Fixes a typo too.

Units depending on block/inline direction still do
not work for vertical writing modes. That's for another CL.

Bug: 1468306
Change-Id: I781a35810133f3591c7a3587ff5d13df0dfac9ee

Reviewed-on: https://chromium-review.googlesource.com/5149171
WPT-Export-Revision: 0bdc58ffb3b73b44a0c34275eec153801f6a85d5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=316dab41ca7447efbc95b206d9b80a83fcb92840

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 3 subtests

Status Summary

Firefox

OK : 2
PASS: 12
FAIL: 6

Chrome

OK : 2
PASS: 14
FAIL: 4

Safari

OK : 2
PASS: 8
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-highlight-api/painting/custom-highlight-container-metrics-001.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-highlight-api/painting/custom-highlight-container-metrics-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-highlight-api/painting/custom-highlight-container-metrics-003.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-highlight-api/painting/custom-highlight-container-metrics-004.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-highlight-api/painting/custom-highlight-container-metrics-005.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-highlight-api/painting/custom-highlight-container-metrics-006.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db9f2698f681
[wpt PR 43848] - Fix Highlight Pseudos using container-relative units, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3e01752abc17
[wpt PR 43848] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/db9f2698f681
https://hg.mozilla.org/mozilla-central/rev/3e01752abc17