187309 - nsIProcess::Run has one out param but is void

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

currently, nsIProcess::Run has one out param, but is of void type. It is used
for the PID of the spawned process.

I'll attach a patch in a second, and also add a bit of documentation to this
function

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: better patch

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

er oops, there is a JS caller of this function which will need a patch too

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch for caller

let's patch the only caller as well

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 110429 [details] [diff] [review]
better patch

Okay.

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 110430 [details] [diff] [review]
patch for caller

okay.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in