1873094 - Update the Firefox View Open Tabs test case to send a click on a menuitem itself instead of its container

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P3)

Description

[Anna Yeddi [:ayeddi]]

The Firefox View provides a custom menu for Open Tab links. This menu is attempted to be clicked twice in the test file browser/components/firefoxview/tests/browser/firefoxview-next/browser_opentabs_firefoxview_next.js. But since the <panel-item> itself has a role of presentation and is serving as a container for an accessible <button role="menuitem">, the automatic accessibility checks are flagging these clicks as ones on a non-accessible elements. We can update the test case to send a click on a menuitem itself to ensure the test is working as expected too, since the keyboard-only users and users of assistive technology would be activating the menuitem.

Since this would allow the a11y_checks to test an actual control and we expect these tests to pass, we need to update the fail-if notation in the test manifest to exclude the panel-item failure.

The a11y_checks output is the following:

Path	Error	El ID	El tagName
browser/components/firefoxview/tests/browser/firefoxview-next/browser_opentabs_firefoxview_next.js	Node is not accessible via accessibility API		PANEL-ITEM

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1873094 - Update the Firefox View Open Tabs test case to send a click on a menuitem itself instead of its container. r=#fxview-reviewers!

The Firefox View provides a custom menu for Open Tab links. This menu is attempted to be clicked twice in the test file browser/components/firefoxview/tests/browser/firefoxview-next/browser_opentabs_firefoxview_next.js. But since the <panel-item> itself has a role of presentation and is serving as a container for an accessible <button role="menuitem">, the automatic accessibility checks are flagging these clicks as ones on a non-accessible elements. We can update the test case to send a click on a menuitem itself to ensure the test is working as expected too, since the keyboard-only users and users of assistive technology would be activating the menuitem.

Since this would allow the a11y_checks to test an actual control and we expect these tests to pass, we need to update the fail-if notation in the test manifest to exclude the panel-item failure.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/957918b1aacd
Update the Firefox View Open Tabs test case to send a click on a menuitem itself instead of its container. r=fxview-reviewers,kcochrane

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/957918b1aacd