Consider enforcing ruff line length
Categories
(Tecken :: General, task)
Tracking
(Not tracked)
People
(Reporter: relud, Unassigned)
Details
[tool.ruff] ... # Ignore line length violations--Black handles those line-length = 88 ignore = ["E501"]
black formatting doesn't fix certain types of line length exceptions, such as when a string literal is too long.
I'm uncertain whether this case is being intentionally ignored as I implement switching to ruff format per https://github.com/mozilla-services/fx-crash-sig/pull/91/files#r1440825162 and https://github.com/mozilla-services/tecken/pull/2869
|
Reporter | |
Comment 1•1 year ago
•
|
||
per willkg in slack:
there are some places where enforcing a line length makes the code riskier or harder to maintain. i think this comes up in tests more than anything else. i had set up ruff the way we did it so i didn't have to deal with those edge cases.
i think if it were just me working on things, i'd keep being lenient on line-length rather than strict because that works fine with my tooling.
beyond that, i could go either way.
Description
•