1873416 - Don't consider Ctrl/Cmd+Enter for stopOnReturn option in InplaceEditor

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

We got feedback about people being surprised of the change made in Bug 1861674.
Although people do understand the reasoning behind this (which will explain and surface in Bug 1871806), they would like their muscle memory to not be disturbed too much, and the idea of having Ctrl+Enter move the editor to the next field was suggested ¹

I think this should be reasonable and not hard to implement, so let's give it a try.

---

¹ 🇫🇷 https://mastodon.social/@Cqoicebordel/111692671502624211

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1873416 - [devtools] Don't consider Ctrl/Cmd+Enter for stopOnReturn option in InplaceEditor. r=#devtools-reviewers.

This will allow user to Ctrl+Enter to get the previous behavior in the Rules view.
A test is added to assert the various stopOnX options of InplaceEditor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27fa64486865
[devtools] Don't consider Ctrl/Cmd+Enter for stopOnReturn option in InplaceEditor. r=devtools-reviewers,jdescottes.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/27fa64486865

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1873416 - [devtools] Don't consider Ctrl/Cmd+Enter for stopOnReturn option in InplaceEditor. r=#devtools-reviewers.

This will allow user to Ctrl+Enter to get the previous behavior in the Rules view.
A test is added to assert the various stopOnX options of InplaceEditor.

Original Revision: https://phabricator.services.mozilla.com/D197897

Comment 5

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• Risk associated with taking this patch: low
• String changes made/needed: -
• Fix verified in Nightly: no
• Explanation of risk level: small devtools only change, covered by mochitest
• Is Android affected?: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• User impact if declined: as we changed an important behavior in the rules view (hitting Enter doesn't move the focus to next input anymore), without this patch, people might be surprised and frustrated that the tool doesn't work the way it used to. We plan to reference this new shortcut in Bug 1871806, which is being worked on and for which we plan to request an uplift as well

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a767de77c36f

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1873416 - [devtools] Don't consider Ctrl/Cmd+Enter for stopOnReturn option in InplaceEditor. r=#devtools-reviewers.

This will allow user to Ctrl+Enter to get the previous behavior in the Rules view.
A test is added to assert the various stopOnX options of InplaceEditor.

Original Revision: https://phabricator.services.mozilla.com/D197897