Closed Bug 1873416 Opened 2 months ago Closed 2 months ago

Don't consider Ctrl/Cmd+Enter for stopOnReturn option in InplaceEditor

Categories

(DevTools :: Inspector: Rules, task)

task

Tracking

(firefox122 fixed, firefox123 fixed)

RESOLVED FIXED
123 Branch
Tracking Status
firefox122 --- fixed
firefox123 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(2 files, 1 obsolete file)

We got feedback about people being surprised of the change made in Bug 1861674.
Although people do understand the reasoning behind this (which will explain and surface in Bug 1871806), they would like their muscle memory to not be disturbed too much, and the idea of having Ctrl+Enter move the editor to the next field was suggested ¹

I think this should be reasonable and not hard to implement, so let's give it a try.


¹ 🇫🇷 https://mastodon.social/@Cqoicebordel/111692671502624211

This will allow user to Ctrl+Enter to get the previous behavior in the Rules view.
A test is added to assert the various stopOnX options of InplaceEditor.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27fa64486865
[devtools] Don't consider Ctrl/Cmd+Enter for stopOnReturn option in InplaceEditor. r=devtools-reviewers,jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch

This will allow user to Ctrl+Enter to get the previous behavior in the Rules view.
A test is added to assert the various stopOnX options of InplaceEditor.

Original Revision: https://phabricator.services.mozilla.com/D197897

Attachment #9371701 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • Code covered by automated testing: yes
  • Risk associated with taking this patch: low
  • String changes made/needed: -
  • Fix verified in Nightly: no
  • Explanation of risk level: small devtools only change, covered by mochitest
  • Is Android affected?: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: -
  • User impact if declined: as we changed an important behavior in the rules view (hitting Enter doesn't move the focus to next input anymore), without this patch, people might be surprised and frustrated that the tool doesn't work the way it used to. We plan to reference this new shortcut in Bug 1871806, which is being worked on and for which we plan to request an uplift as well
Attachment #9371701 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This will allow user to Ctrl+Enter to get the previous behavior in the Rules view.
A test is added to assert the various stopOnX options of InplaceEditor.

Original Revision: https://phabricator.services.mozilla.com/D197897

Attachment #9372211 - Flags: approval-mozilla-beta?
Attachment #9372211 - Attachment is obsolete: true
Attachment #9372211 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.