Update libjxl to new version b26041c708d523ac53bb7d95d4f5c4a5d3b1ce30 from 2024-01-08 13:55:50
Categories
(Core :: Graphics: ImageLib, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: update-bot, Assigned: saschanaz)
Details
(Whiteboard: [3pl-filed][task_id: RrolrB-nSr2iPrh-svPB8g])
Attachments
(1 file)
This update covers 19 commits. Here are the overall diff statistics, and then the commit information.
media/libjxl/moz.yaml | 4 +-
third_party/jpeg-xl/BUILD.bazel | 1 +
third_party/jpeg-xl/deps.sh | 2 +
third_party/jpeg-xl/lib/extras/codec.cc | 4 +-
third_party/jpeg-xl/lib/extras/dec/decode.cc | 39 +-
third_party/jpeg-xl/lib/extras/dec/decode.h | 1 -
third_party/jpeg-xl/lib/extras/dec/jxl.cc | 4 +-
third_party/jpeg-xl/lib/extras/enc/jxl.cc | 2 +-
third_party/jpeg-xl/lib/include/jxl/encode.h | 6 +-
third_party/jpeg-xl/lib/jxl/base/exif.h | 91 +++++
third_party/jpeg-xl/lib/jxl/cms/color_encoding_cms.h | 3 -
third_party/jpeg-xl/lib/jxl/cms/jxl_cms_internal.h | 8 +-
third_party/jpeg-xl/lib/jxl/cms/tone_mapping.h | 9 +-
third_party/jpeg-xl/lib/jxl/cms/transfer_functions.h | 1 -
third_party/jpeg-xl/lib/jxl/color_encoding_internal.h | 1 -
third_party/jpeg-xl/lib/jxl/convolve.h | 12 +-
third_party/jpeg-xl/lib/jxl/convolve_separable5.cc | 2 +-
third_party/jpeg-xl/lib/jxl/convolve_separable7.cc | 2 +-
third_party/jpeg-xl/lib/jxl/convolve_slow.cc | 60 +-
third_party/jpeg-xl/lib/jxl/convolve_symmetric5.cc | 72 ++-
third_party/jpeg-xl/lib/jxl/convolve_test.cc | 58 ++-
third_party/jpeg-xl/lib/jxl/enc_ac_strategy.cc | 64 +--
third_party/jpeg-xl/lib/jxl/enc_ac_strategy.h | 21 +-
third_party/jpeg-xl/lib/jxl/enc_adaptive_quantization.cc | 151 ++++----
third_party/jpeg-xl/lib/jxl/enc_adaptive_quantization.h | 7 +-
third_party/jpeg-xl/lib/jxl/enc_ar_control_field.cc | 63 +-
third_party/jpeg-xl/lib/jxl/enc_ar_control_field.h | 9 +-
third_party/jpeg-xl/lib/jxl/enc_aux_out.cc | 4 +
third_party/jpeg-xl/lib/jxl/enc_cache.cc | 7 +-
third_party/jpeg-xl/lib/jxl/enc_cache.h | 8 +-
third_party/jpeg-xl/lib/jxl/enc_chroma_from_luma.cc | 35 +-
third_party/jpeg-xl/lib/jxl/enc_chroma_from_luma.h | 4 +-
third_party/jpeg-xl/lib/jxl/enc_cluster.cc | 40 +-
third_party/jpeg-xl/lib/jxl/enc_fast_lossless.cc | 80 ++--
third_party/jpeg-xl/lib/jxl/enc_fast_lossless.h | 2 +-
third_party/jpeg-xl/lib/jxl/enc_fields.cc | 2 +
third_party/jpeg-xl/lib/jxl/enc_frame.cc | 130 ++++---
third_party/jpeg-xl/lib/jxl/enc_gaborish.cc | 11 +-
third_party/jpeg-xl/lib/jxl/enc_gaborish.h | 3 +-
third_party/jpeg-xl/lib/jxl/enc_gaborish_test.cc | 2 +-
third_party/jpeg-xl/lib/jxl/enc_group.cc | 10 +-
third_party/jpeg-xl/lib/jxl/enc_group.h | 2 +-
third_party/jpeg-xl/lib/jxl/enc_heuristics.cc | 167 +++++----
third_party/jpeg-xl/lib/jxl/enc_heuristics.h | 4 +-
third_party/jpeg-xl/lib/jxl/enc_modular.cc | 2 +-
third_party/jpeg-xl/lib/jxl/encode.cc | 4 +-
third_party/jpeg-xl/lib/jxl/encode_internal.h | 2 +
third_party/jpeg-xl/lib/jxl/encode_test.cc | 61 +++
third_party/jpeg-xl/lib/jxl/exif.h | 86 -----
third_party/jpeg-xl/lib/jxl/fields.cc | 4 +-
third_party/jpeg-xl/lib/jxl/fields.h | 11 +-
third_party/jpeg-xl/lib/jxl/icc_codec_common.cc | 4 +-
third_party/jpeg-xl/lib/jxl/icc_codec_common.h | 2 +-
third_party/jpeg-xl/lib/jxl/image.h | 12 +
third_party/jpeg-xl/lib/jxl/modular/encoding/enc_debug_tree.cc | 5 +-
third_party/jpeg-xl/lib/jxl/modular/transform/transform.cc | 2 +
third_party/jpeg-xl/lib/jxl/render_pipeline/stage_write.cc | 120 +++++-
third_party/jpeg-xl/lib/jxl/sanitizers.h | 2 +-
third_party/jpeg-xl/lib/jxl/splines.cc | 1 +
third_party/jpeg-xl/lib/jxl/test_utils.cc | 5 +
third_party/jpeg-xl/lib/jxl_lists.bzl | 2 +-
third_party/jpeg-xl/lib/jxl_lists.cmake | 2 +-
62 files changed, 888 insertions(+), 647 deletions(-)
b26041c708d523ac53bb7d95d4f5c4a5d3b1ce30 by Eugene Kliuchnikov
https://github.com/libjxl/libjxl/commit/b26041c708d523ac53bb7d95d4f5c4a5d3b1ce30
Authored: 2024-01-08 14:55:50 +0100
Committed: 2024-01-08 13:55:50 +0000
Re-add jxl.dll asset (#3117)
Files Modified:
- .github/workflows/release.yaml
7638e923b330222651bf6e97ac708dfa28395b69 by Eugene Kliuchnikov
https://github.com/libjxl/libjxl/commit/7638e923b330222651bf6e97ac708dfa28395b69
Authored: 2024-01-08 11:24:25 +0100
Committed: 2024-01-08 10:24:25 +0000
Fix install prefix in documentation (#3116)
Files Modified:
- doc/release.md
875e72dd1e3e2d71835aa2490f595a7d5968199e by Sami Boukortt
https://github.com/libjxl/libjxl/commit/875e72dd1e3e2d71835aa2490f595a7d5968199e
Authored: 2024-01-06 12:29:40 +0100
Committed: 2024-01-06 11:29:40 +0000
Update testdata (#3112)
This pulls in: https://github.com/libjxl/testdata/pull/22
Files Modified:
- testdata
9a644b55fdc0d83707934aebf9f1941a9a99db17 by Eugene Kliuchnikov
https://github.com/libjxl/libjxl/commit/9a644b55fdc0d83707934aebf9f1941a9a99db17
Authored: 2024-01-05 20:37:44 +0100
Committed: 2024-01-05 19:37:44 +0000
Fix Clang Tidy findings (#3107)
Files Modified:
- lib/jxl/cms/color_encoding_cms.h
- lib/jxl/cms/jxl_cms_internal.h
- lib/jxl/cms/tone_mapping.h
- lib/jxl/cms/transfer_functions.h
- lib/jxl/color_encoding_internal.h
- tools/djxl_fuzzer_corpus.cc
e3ad9e18f3578f6f7438808b8542d56f1690065d by szabadka
https://github.com/libjxl/libjxl/commit/e3ad9e18f3578f6f7438808b8542d56f1690065d
Authored: 2024-01-05 19:37:23 +0100
Committed: 2024-01-05 18:37:23 +0000
Enable Gaborish for streaming mode. (#3108)
Benchmark results:
Encoding kPixels Bytes BPP E MP/s D MP/s Max norm SSIMULACRA2 PSNR pnorm BPP*pnorm QABPP Bugs
-------------------------------------------------------------------------------------------------------------------------------------------
BEFORE:
jxl:d1:1:buf3 156870 30083811 1.5341986 10.752 38.434 1.43588506 86.14940783 43.59 0.58841531 0.902745969086 2.236 0
jxl:d1:3:buf3 156870 28045193 1.4302342 9.866 36.601 1.43588506 86.14940783 43.59 0.58841531 0.841571732152 2.083 0
jxl:d1:4:buf3 156870 28554209 1.4561928 9.028 26.851 1.43953718 86.43275684 43.61 0.58675396 0.854426882480 2.124 0
jxl:d1:5:buf3 156870 23633360 1.2052419 3.013 39.530 1.79721683 84.31625183 43.00 0.62510227 0.753399425182 2.200 0
jxl:d1:6:buf3 156870 23674553 1.2073426 1.983 33.965 1.79445658 84.33377882 43.02 0.62494042 0.754517195337 2.198 0
jxl:d1:7:buf3 156870 23673497 1.2072888 1.838 35.483 1.79768241 84.34806803 43.03 0.62501552 0.754574202894 2.200 0
Aggregate: 156870 26140979 1.3331241 4.681 34.876 1.60676159 85.28287355 43.31 0.60615554 0.808080568276 2.173 0
AFTER:
jxl:d1:1:buf3 156870 30083811 1.5341986 10.613 33.186 1.43588506 86.14940783 43.59 0.58841531 0.902745969086 2.236 0
jxl:d1:3:buf3 156870 28045193 1.4302342 9.603 27.285 1.43588506 86.14940783 43.59 0.58841531 0.841571732152 2.083 0
jxl:d1:4:buf3 156870 28554209 1.4561928 9.798 36.369 1.43953718 86.43275684 43.61 0.58675396 0.854426882480 2.124 0
jxl:d1:5:buf3 156870 23896866 1.2186800 2.893 32.202 1.55262351 84.46145230 43.60 0.58417125 0.711917821691 1.924 0
jxl:d1:6:buf3 156870 23920039 1.2198618 1.966 33.068 1.55949380 84.52573644 43.61 0.58583763 0.714640932605 1.931 0
jxl:d1:7:buf3 156870 23905801 1.2191357 1.902 32.774 1.57113087 84.54468962 43.62 0.58616382 0.714613224299 1.941 0
Aggregate: 156870 26277130 1.3400675 4.702 32.365 1.49780084 85.37278849 43.60 0.58662433 0.786116177600 2.037 0
Files Modified:
- lib/include/jxl/encode.h
- lib/jxl/enc_ac_strategy.cc
- lib/jxl/enc_ac_strategy.h
- lib/jxl/enc_adaptive_quantization.cc
- lib/jxl/enc_adaptive_quantization.h
- lib/jxl/enc_ar_control_field.cc
- lib/jxl/enc_ar_control_field.h
- lib/jxl/enc_cache.cc
- lib/jxl/enc_cache.h
- lib/jxl/enc_chroma_from_luma.cc
- lib/jxl/enc_chroma_from_luma.h
- lib/jxl/enc_frame.cc
- lib/jxl/enc_gaborish.cc
- lib/jxl/enc_gaborish.h
- lib/jxl/enc_gaborish_test.cc
- lib/jxl/enc_group.cc
- lib/jxl/enc_group.h
- lib/jxl/enc_heuristics.cc
- lib/jxl/enc_heuristics.h
- lib/jxl/enc_modular.cc
- lib/jxl/image.h
7b2db1857213c87976c7eb104fe02438d325c72b by Eugene Kliuchnikov
https://github.com/libjxl/libjxl/commit/7b2db1857213c87976c7eb104fe02438d325c72b
Authored: 2024-01-05 15:57:52 +0100
Committed: 2024-01-05 14:57:52 +0000
Move exif.h to base/ (#3105)
Files Modified:
- lib/extras/dec/jxl.cc
- lib/extras/enc/jxl.cc
- lib/jxl/enc_fields.cc
- lib/jxl/encode.cc
- lib/jxl/fields.cc
- lib/jxl/fields.h
- lib/jxl/image.h
- lib/jxl/modular/encoding/enc_debug_tree.cc
- lib/jxl/modular/transform/transform.cc
- lib/jxl/sanitizers.h
- lib/jxl/splines.cc
- lib/jxl_lists.bzl
- lib/jxl_lists.cmake
- tools/args.h
- tools/cjxl_main.cc
Files Changed:
- R084 lib/jxl/exif.h
c50a3bf8fa2932f45438ccda714b72ad7d104167 by Moritz Firsching
https://github.com/libjxl/libjxl/commit/c50a3bf8fa2932f45438ccda714b72ad7d104167
Authored: 2024-01-05 14:08:45 +0100
Committed: 2024-01-05 13:08:45 +0000
remove Compact-ICC-Profiles submodule (#3103)
-
update testdata repo
-
remove Compact-ICC-Profiles submodule
-
more absolute path
Files Deleted:
- third_party/Compact-ICC-Profiles
Files Modified:
- .github/workflows/build_test_cross.yml
- .gitmodules
- BUILD.bazel
- deps.sh
- lib/jxl/encode_test.cc
- testdata
6e7798521b53efef5ed66b185dfbe3c5ad3362fb by Moritz Firsching
https://github.com/libjxl/libjxl/commit/6e7798521b53efef5ed66b185dfbe3c5ad3362fb
Authored: 2024-01-05 11:10:02 +0100
Committed: 2024-01-05 10:10:02 +0000
add Compact-ICC-Profiles to testdata filegroup (#3102)
Files Modified:
- BUILD.bazel
2a7b35f6f29a288496232bb62c65a706209b5557 by Moritz Firsching
https://github.com/libjxl/libjxl/commit/2a7b35f6f29a288496232bb62c65a706209b5557
Authored: 2024-01-04 18:53:38 +0100
Committed: 2024-01-04 17:53:38 +0000
in cross test also have artifacts for Compact-ICC-Profiles (#3099)
Files Modified:
- .github/workflows/build_test_cross.yml
22899bbea3019e0847b1dbac23447061784e2eb5 by szabadka
https://github.com/libjxl/libjxl/commit/22899bbea3019e0847b1dbac23447061784e2eb5
Authored: 2024-01-04 18:18:24 +0100
Committed: 2024-01-04 17:18:24 +0000
Make convolution work for arbitrary input/output rectangles. (#3094)
This is for now only implemented for the slow mode and the symmetric5
mode, others are not needed for the streaming encoder.
Files Modified:
- lib/jxl/convolve.h
- lib/jxl/convolve_separable5.cc
- lib/jxl/convolve_separable7.cc
- lib/jxl/convolve_slow.cc
- lib/jxl/convolve_symmetric5.cc
- lib/jxl/convolve_test.cc
e4764a3792d8f8bb627498e7c29ced32d295e345 by Luca Versari
https://github.com/libjxl/libjxl/commit/e4764a3792d8f8bb627498e7c29ced32d295e345
Authored: 2024-01-04 17:31:47 +0100
Committed: 2024-01-04 16:31:47 +0000
Fix CheckOutOfBounds on 32-bit systems. (#3098)
Files Modified:
- lib/jxl/icc_codec_common.cc
- lib/jxl/icc_codec_common.h
3cac2874bb125c901f1703065f658e32e7c85cee by Sami Boukortt
https://github.com/libjxl/libjxl/commit/3cac2874bb125c901f1703065f658e32e7c85cee
Authored: 2024-01-04 16:24:15 +0100
Committed: 2024-01-04 15:24:15 +0000
Fix CMYK encoding (#3096)
- Fix CMYK encoding
Fixes #3078.
Co-authored-by: Luca Versari <veluca@google.com>
- add Compact-ICC-Profiles to deps.sh
Co-authored-by: Luca Versari <veluca@google.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
Files Added:
- third_party/Compact-ICC-Profiles
Files Modified:
- .gitmodules
- deps.sh
- lib/jxl/cms/color_encoding_cms.h
- lib/jxl/encode_test.cc
3428233bc3b7ae7b67d27365942385c32b1052a2 by Moritz Firsching
https://github.com/libjxl/libjxl/commit/3428233bc3b7ae7b67d27365942385c32b1052a2
Authored: 2024-01-04 16:19:50 +0100
Committed: 2024-01-04 15:19:50 +0000
add testdata to deps.sh (#3097)
Files Modified:
- deps.sh
06aec61435eab1c511c4c809e5ebd637c2551839 by Luca Versari
https://github.com/libjxl/libjxl/commit/06aec61435eab1c511c4c809e5ebd637c2551839
Authored: 2024-01-04 13:06:15 +0100
Committed: 2024-01-04 12:06:15 +0000
Fix dithering when doing non-8-aligned processing. (#3093)
Files Modified:
- lib/jxl/render_pipeline/stage_write.cc
cdc12b32e1344381aa1e8d15ea26984789e7534f by Moritz Firsching
https://github.com/libjxl/libjxl/commit/cdc12b32e1344381aa1e8d15ea26984789e7534f
Authored: 2024-01-04 13:00:23 +0100
Committed: 2024-01-04 12:00:23 +0000
refactor file extension handling (#3088)
-
refactor file extension handling
-
remove filename args
-
format
Files Modified:
- lib/extras/codec.cc
- lib/extras/dec/decode.cc
- lib/extras/dec/decode.h
- tools/djxl_main.cc
0d876275904f64c9587475f524353d81df5254c8 by Sergey Fedorov
https://github.com/libjxl/libjxl/commit/0d876275904f64c9587475f524353d81df5254c8
Authored: 2024-01-04 16:40:12 +0800
Committed: 2024-01-04 08:40:12 +0000
enc_aux_out.cc: define __STDC_FORMAT_MACROS if undefined (#3092)
Fixes: https://github.com/libjxl/libjxl/issues/3091
See also: https://github.com/libjxl/libjxl/commit/97ec970d06ad04254f2cdcbe0bf8bba3166372b6
Files Modified:
- lib/jxl/enc_aux_out.cc
815858b2335c267727c4b438cfdc00d5499791e0 by Luca Versari
https://github.com/libjxl/libjxl/commit/815858b2335c267727c4b438cfdc00d5499791e0
Authored: 2024-01-03 23:56:52 +0100
Committed: 2024-01-03 22:56:52 +0000
Do 8-bit ordered dithering when decoding to 8-bit. (#3090)
This should help mitigating banding.
Files Modified:
- lib/jxl/render_pipeline/stage_write.cc
- lib/jxl/test_utils.cc
34b43a0a5868e07f525c3c7c26ac052c0aa039ac by Luca Versari
https://github.com/libjxl/libjxl/commit/34b43a0a5868e07f525c3c7c26ac052c0aa039ac
Authored: 2024-01-03 16:39:48 +0100
Committed: 2024-01-03 15:39:48 +0000
Improve histogram selection/clustering when in streaming mode. (#3089)
About 0.1% density improvement.
Before:
Encoding kPixels Bytes BPP E MP/s D MP/s Max norm SSIMULACRA2 PSNR pnorm BPP*pnorm QABPP Bugs
---------------------------------------------------------------------------------------------------------------------------------------------
jxl:d0.1:1 156870 125498985 6.4001323 10.481 25.622 0.33339046 93.97832386 55.04 0.11910776 0.762305449452 6.400 0
jxl:d0.1:3 156870 118196434 6.0277206 9.531 22.580 0.33339046 93.97832386 55.04 0.11910776 0.717948322403 6.028 0
jxl:d0.1:4 156870 117891989 6.0121947 8.962 22.995 0.33382919 93.98281550 55.04 0.11907582 0.715907017487 6.012 0
jxl:d0.1:5 156870 139407419 7.1094274 0.265 19.130 0.34058526 93.91756615 57.02 0.10181724 0.723862276699 7.109 0
jxl:d0.1:6 156870 140721297 7.1764319 0.094 18.938 0.34023609 93.88851051 57.11 0.10187577 0.731104514949 7.176 0
jxl:d0.1:7 156870 141506384 7.2164694 0.109 19.439 0.33378356 93.90513043 57.19 0.10142270 0.731913822828 7.216 0
jxl:d0.1:1:buf3 156870 124186343 6.3331909 10.481 26.377 0.33339046 93.97832386 55.04 0.11910776 0.754332204491 6.333 0
jxl:d0.1:3:buf3 156870 118645473 6.0506205 10.047 23.451 0.33339046 93.97832386 55.04 0.11910776 0.720675873361 6.051 0
jxl:d0.1:4:buf3 156870 119051575 6.0713306 9.621 23.586 0.33382919 93.98281550 55.04 0.11907582 0.722948681317 6.071 0
jxl:d0.1:5:buf3 156870 124956524 6.3724682 0.273 21.745 0.42522476 93.89009490 55.38 0.11737117 0.747944032977 6.372 0
jxl:d0.1:6:buf3 156870 125038135 6.3766301 0.095 21.828 0.42531876 93.89079655 55.40 0.11745915 0.748993546453 6.377 0
jxl:d0.1:7:buf3 156870 125896354 6.4203971 0.109 21.945 0.43496897 93.92178756 55.47 0.11689823 0.750533029277 6.420 0
jxl:d1:1 156870 30373609 1.5489776 15.022 42.074 1.43588631 86.15262815 43.59 0.58841542 0.911442303646 2.257 0
jxl:d1:3 156870 27841572 1.4198501 15.455 39.778 1.43588631 86.15262815 43.59 0.58841542 0.835461683885 2.068 0
jxl:d1:4 156870 28110275 1.4335533 14.663 38.451 1.43953851 86.42380933 43.61 0.58675407 0.841143209010 2.092 0
jxl:d1:5 156870 23502237 1.1985549 0.275 31.501 1.49287343 84.49051774 43.63 0.58180380 0.697323807038 1.816 0
jxl:d1:6 156870 23686907 1.2079726 0.110 36.715 1.48966367 84.58305904 43.65 0.58294525 0.704181902461 1.829 0
jxl:d1:7 156870 23680839 1.2076632 0.121 37.204 1.49379576 84.60500389 43.66 0.58316878 0.704271456582 1.829 0
jxl:d1:1:buf3 156870 30144398 1.5372884 14.712 41.039 1.43588631 86.15262815 43.59 0.58841542 0.904564207537 2.240 0
jxl:d1:3:buf3 156870 28077983 1.4319065 15.833 38.104 1.43588631 86.15262815 43.59 0.58841542 0.842555835470 2.085 0
jxl:d1:4:buf3 156870 28586708 1.4578501 14.897 38.708 1.43953851 86.42380933 43.61 0.58675407 0.855399504351 2.127 0
jxl:d1:5:buf3 156870 23664692 1.2068397 0.275 34.632 1.79721829 84.31671572 43.00 0.62510236 0.754398358453 2.203 0
jxl:d1:6:buf3 156870 23700533 1.2086675 0.111 39.659 1.79445691 84.33156210 43.02 0.62494051 0.755345298026 2.201 0
jxl:d1:7:buf3 156870 23699715 1.2086258 0.124 41.240 1.79768254 84.35222227 43.03 0.62501560 0.755409986047 2.202 0
jxl:d10:1 156870 4634629 0.2363544 19.190 17.400 6.71570749 38.19811705 35.71 2.25288390 0.532479049078 1.600 0
jxl:d10:3 156870 3819655 0.1947928 21.055 16.339 6.71570749 38.19811705 35.71 2.25288390 0.438845539137 1.320 0
jxl:d10:4 156870 4137919 0.2110235 19.777 18.844 6.71726398 40.72037264 35.94 2.19382484 0.462948493303 1.427 0
jxl:d10:5 156870 3064736 0.1562938 0.279 17.525 9.14517323 30.37019456 35.23 2.69294020 0.420889913442 1.429 0
jxl:d10:6 156870 3123745 0.1593031 0.119 18.238 9.35054060 31.50078128 35.32 2.68063202 0.427033076325 1.496 0
jxl:d10:7 156870 3129105 0.1595765 0.125 18.720 9.23112211 31.60315457 35.33 2.67094518 0.426220024687 1.486 0
jxl:d10:1:buf3 156870 4788892 0.2442214 20.003 17.769 6.71570749 38.19811705 35.71 2.25288390 0.550202542274 1.652 0
jxl:d10:3:buf3 156870 4017087 0.2048613 21.103 18.622 6.71570749 38.19811705 35.71 2.25288390 0.461528779504 1.388 0
jxl:d10:4:buf3 156870 4396053 0.2241876 20.190 18.997 6.71726398 40.72037264 35.94 2.19382484 0.491828407668 1.516 0
jxl:d10:5:buf3 156870 3738546 0.1906564 0.279 17.463 7.36732187 37.57982185 35.82 2.26285878 0.431428588693 1.419 0
jxl:d10:6:buf3 156870 3790243 0.1932929 0.120 18.658 7.39669119 38.22734998 35.86 2.25680877 0.436225003154 1.442 0
jxl:d10:7:buf3 156870 3791016 0.1933323 0.127 18.970 7.40258647 38.25430412 35.86 2.25490325 0.435945570012 1.444 0
Aggregate: 156870 23301886 1.1883375 1.481 24.841 1.59684563 66.47794881 44.19 0.54200043 0.644079450581 2.696 0
After:
Encoding kPixels Bytes BPP E MP/s D MP/s Max norm SSIMULACRA2 PSNR pnorm BPP*pnorm QABPP Bugs
---------------------------------------------------------------------------------------------------------------------------------------------
jxl:d0.1:1 156870 125498985 6.4001323 10.296 27.037 0.33339046 93.97832386 55.04 0.11910776 0.762305449452 6.400 0
jxl:d0.1:3 156870 118196434 6.0277206 9.175 23.001 0.33339046 93.97832386 55.04 0.11910776 0.717948322403 6.028 0
jxl:d0.1:4 156870 117891989 6.0121947 8.950 22.643 0.33382919 93.98281550 55.04 0.11907582 0.715907017487 6.012 0
jxl:d0.1:5 156870 139407419 7.1094274 0.262 19.012 0.34058526 93.91756615 57.02 0.10181724 0.723862276699 7.109 0
jxl:d0.1:6 156870 140721297 7.1764319 0.092 19.311 0.34023609 93.88851051 57.11 0.10187577 0.731104514949 7.176 0
jxl:d0.1:7 156870 141506384 7.2164694 0.107 19.252 0.33378356 93.90513043 57.19 0.10142270 0.731913822828 7.216 0
jxl:d0.1:1:buf3 156870 123997709 6.3235710 10.295 26.541 0.33339046 93.97832386 55.04 0.11910776 0.753186404578 6.324 0
jxl:d0.1:3:buf3 156870 118508737 6.0436473 9.932 23.437 0.33339046 93.97832386 55.04 0.11910776 0.719845312078 6.044 0
jxl:d0.1:4:buf3 156870 118953603 6.0663343 9.514 23.772 0.33382919 93.98281550 55.04 0.11907582 0.722353739770 6.066 0
jxl:d0.1:5:buf3 156870 124863707 6.3677347 0.262 20.874 0.42522476 93.89009490 55.38 0.11737117 0.747388464376 6.368 0
jxl:d0.1:6:buf3 156870 124953497 6.3723138 0.091 22.218 0.42531876 93.89079655 55.40 0.11745915 0.748486554599 6.372 0
jxl:d0.1:7:buf3 156870 125811491 6.4160693 0.107 22.104 0.43496897 93.92178756 55.47 0.11689823 0.750027117212 6.416 0
jxl:d1:1 156870 30373609 1.5489776 13.785 38.208 1.43588631 86.15262815 43.59 0.58841542 0.911442303646 2.257 0
jxl:d1:3 156870 27841572 1.4198501 15.909 39.486 1.43588631 86.15262815 43.59 0.58841542 0.835461683885 2.068 0
jxl:d1:4 156870 28110275 1.4335533 13.620 37.650 1.43953851 86.42380933 43.61 0.58675407 0.841143209010 2.092 0
jxl:d1:5 156870 23502237 1.1985549 0.265 31.275 1.49287343 84.49051774 43.63 0.58180380 0.697323807038 1.816 0
jxl:d1:6 156870 23686907 1.2079726 0.106 36.519 1.48966367 84.58305904 43.65 0.58294525 0.704181902461 1.829 0
jxl:d1:7 156870 23680839 1.2076632 0.120 37.442 1.49379576 84.60500389 43.66 0.58316878 0.704271456582 1.829 0
jxl:d1:1:buf3 156870 30083813 1.5341987 15.116 43.735 1.43588631 86.15262815 43.59 0.58841542 0.902746190720 2.236 0
jxl:d1:3:buf3 156870 28045193 1.4302342 15.532 38.700 1.43588631 86.15262815 43.59 0.58841542 0.841571882818 2.083 0
jxl:d1:4:buf3 156870 28554209 1.4561928 15.076 39.600 1.43953851 86.42380933 43.61 0.58675407 0.854427037409 2.124 0
jxl:d1:5:buf3 156870 23633360 1.2052419 0.270 36.546 1.79721829 84.31671572 43.00 0.62510236 0.753399536691 2.200 0
jxl:d1:6:buf3 156870 23674553 1.2073426 0.107 40.386 1.79445691 84.33156210 43.02 0.62494051 0.754517305220 2.198 0
jxl:d1:7:buf3 156870 23673497 1.2072888 0.121 39.323 1.79768254 84.35222227 43.03 0.62501560 0.754574307684 2.200 0
jxl:d10:1 156870 4634629 0.2363544 19.196 18.297 6.71570749 38.19811705 35.71 2.25288390 0.532479049078 1.600 0
jxl:d10:3 156870 3819655 0.1947928 21.619 18.495 6.71570749 38.19811705 35.71 2.25288390 0.438845539137 1.320 0
jxl:d10:4 156870 4137919 0.2110235 19.292 18.465 6.71726398 40.72037264 35.94 2.19382484 0.462948493303 1.427 0
jxl:d10:5 156870 3064736 0.1562938 0.268 17.713 9.14517323 30.37019456 35.23 2.69294020 0.420889913442 1.429 0
jxl:d10:6 156870 3123745 0.1593031 0.117 18.369 9.35054060 31.50078128 35.32 2.68063202 0.427033076325 1.496 0
jxl:d10:7 156870 3129105 0.1595765 0.121 18.981 9.23112211 31.60315457 35.33 2.67094518 0.426220024687 1.486 0
jxl:d10:1:buf3 156870 4785566 0.2440518 18.515 18.210 6.71570749 38.19811705 35.71 2.25288390 0.549820413453 1.651 0
jxl:d10:3:buf3 156870 4009051 0.2044515 20.650 18.663 6.71570749 38.19811705 35.71 2.25288390 0.460605512153 1.385 0
jxl:d10:4:buf3 156870 4388003 0.2237771 20.615 19.101 6.71726398 40.72037264 35.94 2.19382484 0.490927777334 1.513 0
jxl:d10:5:buf3 156870 3733241 0.1903859 0.270 17.772 7.36732187 37.57982185 35.82 2.26285878 0.430816391153 1.417 0
jxl:d10:6:buf3 156870 3785529 0.1930524 0.117 18.407 7.39669119 38.22734998 35.86 2.25680877 0.435682461511 1.440 0
jxl:d10:7:buf3 156870 3786179 0.1930856 0.124 18.708 7.40258647 38.25430412 35.86 2.25490325 0.435389342150 1.442 0
Aggregate: 156870 23287709 1.1876145 1.449 25.022 1.59684563 66.47794881 44.19 0.54200043 0.643687598787 2.694 0
Files Modified:
- lib/jxl/enc_cluster.cc
a010c1f8ffa7e379b1f7fb8f0c4a315e79371082 by Luca Versari
https://github.com/libjxl/libjxl/commit/a010c1f8ffa7e379b1f7fb8f0c4a315e79371082
Authored: 2024-01-02 13:41:51 +0100
Committed: 2024-01-02 12:41:51 +0000
Modify the sampling algorithm in fast-lossless streaming mode. (#3084)
This should reduce the amount of input requests significantly.
Files Modified:
- lib/jxl/enc_fast_lossless.cc
- lib/jxl/enc_fast_lossless.h
- lib/jxl/encode.cc
- lib/jxl/encode_internal.h
|
Reporter | |
Comment 1•2 years ago
|
||
| RrolrB-nSr2iPrh-svPB8g | ||
./mach vendor media/libjxl/moz.yaml reported an error editing moz.build files:
Latest commit is b26041c708d523ac53bb7d95d4f5c4a5d3b1ce30 from 2024-01-08T13:55:50Z
Fetching code archive from https://github.com/libjxl/libjxl/archive/b26041c708d523ac53bb7d95d4f5c4a5d3b1ce30.tar.gz
Retaining wanted in-tree files.
Cleaning third_party/jpeg-xl to import changes.
Unpacking upstream files for third_party/jpeg-xl.
Retaining wanted files from upstream changes.
Removing excluded files from upstream changes.
Removing: [/tmp/tmpqj42rbf5/.github/ISSUE_TEMPLATE/bug_report.md, /tmp/tmpqj42rbf5/.github/ISSUE_TEMPLATE/feature_request.md, /tmp/tmpqj42rbf5/.github/PULL_REQUEST_TEMPLATE.md, /tmp/tmpqj42rbf5/.github/dependabot.yml, 18 (omitted) items in /tmp/tmpqj42rbf5/.github/workflows, /tmp/tmpqj42rbf5/.gitignore, /tmp/tmpqj42rbf5/.gitmodules, 19 (omitted) items in /tmp/tmpqj42rbf5/doc, /tmp/tmpqj42rbf5/doc/man/cjxl.txt, /tmp/tmpqj42rbf5/doc/man/djxl.txt, 11 (omitted) items in /tmp/tmpqj42rbf5/doc/sphinx, 47 (omitted) items in /tmp/tmpqj42rbf5/tools, 23 (omitted) items in /tmp/tmpqj42rbf5/tools/benchmark, 3 items in /tmp/tmpqj42rbf5/tools/benchmark/hm: README.md, decode.sh and encode.sh, 18 (omitted) items in /tmp/tmpqj42rbf5/tools/benchmark/metrics, 16 (omitted) items in /tmp/tmpqj42rbf5/tools/comparison_viewer, 5 items in /tmp/tmpqj42rbf5/tools/conformance: CMakeLists.txt, conformance.py, generator.py, lcms2.py and tooling_test.sh, 7 items in /tmp/tmpqj42rbf5/tools/fast_lossless: .gitignore, README.md, build-android.sh, build.sh, cross_compile_aarch64.sh, fast_lossless_main.cc and pam-input.h, 12 (omitted) items in /tmp/tmpqj42rbf5/tools/flicker_test, 10 (omitted) items in /tmp/tmpqj42rbf5/tools/hdr, 4 items in /tmp/tmpqj42rbf5/tools/icc_detect: icc_detect.h, icc_detect_empty.cc, icc_detect_win32.cc and icc_detect_x11.cc, 10 (omitted) items in /tmp/tmpqj42rbf5/tools/jni/org/jpeg/jpegxl/wrapper, 3 items in /tmp/tmpqj42rbf5/tools/optimizer: apply_simplex.py, simplex_fork.py and update_jpegli_global_scale.py, 19 (omitted) items in /tmp/tmpqj42rbf5/tools/scripts, /tmp/tmpqj42rbf5/tools/upscaling_coefficients/generate_upscaling_coefficients.py, /tmp/tmpqj42rbf5/tools/upscaling_coefficients/upscaler_demo.py, 7 items in /tmp/tmpqj42rbf5/tools/viewer: CMakeLists.txt, load_jxl.cc, load_jxl.h, main.cc, viewer_window.cc, viewer_window.h and viewer_window.ui, 16 (omitted) items in /tmp/tmpqj42rbf5/tools/wasm_demo, /tmp/tmpqj42rbf5/tools/wasm_demo/netlify/edge-functions/precompressed.ts]
Copying to third_party/jpeg-xl.
Checking for update actions
Registering changes with version control.
Checking for a spurious update.
Version 'b26041c708d523ac53bb7d95d4f5c4a5d3b1ce30' has changed 61 files.
Updating moz.yaml.
Found release: 1d1006ce9dbe4224c1299992b57f28a4f62df9b7 (2023-12-29T13:36:27Z).Found revision: 1d1006ce9dbe4224c1299992b57f28a4f62df9b7
Updating moz.build files
Found 0 files added and 1 files removed.
Could not remove third_party/jpeg-xl/lib/jxl/exif.h from the appropriate moz.build file
This is a deficiency in ./mach vendor . Please review the affected files before committing.
We're going to continue processing the update; but we may fail because we couldn't handle these files. If we do succeed, you may want to add these files to the 'exclude' key in the moz.yaml file, so they are excluded from the source tree and ignored in the future.
|
|
Reporter | |
Comment 2•2 years ago
|
||
| RrolrB-nSr2iPrh-svPB8g | ||
I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=0de4054a3147482be95c100718de6d829e98045e
|
|
Reporter | |
Comment 3•2 years ago
|
||
|
||
Comment 4•2 years ago
|
||
Hey, it built and seems to have tested mostly successfully! I noted two failures from the Try build:
test-windows11-32-2009-qr/opt-reftest-wr-dc2-o-1/R1, which I have retriggered to see if it is a permanent failure.test-macosx1015-64-qr/opt-gtest-1proc/GTest-1proc, which has been retriggered and passed in CI. At worst, this is an intermittent issue, but it is unclear to me if this is a regression from this change specifically.
Not sure who to ping here, but I'll NI :tnikkel and CC :saschanaz for next steps in triaging these failures.
|
Assignee | |
Comment 5•2 years ago
|
||
... the bot stopped CC'ing me? Per https://searchfox.org/mozilla-central/rev/43c40b22c776d098afb89d5237da3464a7545532/media/libjxl/moz.yaml#21-23 I'm still the maintainer, so I'm not sure why the bot started ignoring me 😄
(In reply to Erich Gubler [:ErichDonGubler] from comment #4)
Hey, it built and seems to have tested mostly successfully! I noted two failures from the Try build:
As long as they are not JXL gtest failures I'm not worried about them 👍 (All JXL tests are in gtests and the gtest failure here is about libcubeb, which is about audio.)
|
|
Assignee | |
Comment 6•2 years ago
|
||
Hi Tom, are you still the person behind Updatebot? Any idea why the bot did not request any review for this patch? (jewilde seems not active anymore.)
|
|
||
Updated•2 years ago
|
|
||
Comment 7•2 years ago
|
||
Let's wait a few hours until Updatebot checks and sees that the try run is completed - it will probably reach out to you (either with a review request or a needinfo) then. It waits until it has the try run results so you don't get flagged until you've got the information you need to do something, and it runs every 6 hours.
|
|
Assignee | |
Comment 8•2 years ago
|
||
Makes sense, thanks!
|
|
Reporter | |
Comment 9•2 years ago
|
||
| NWEt6c04QY69qoVi4Fly0A | ||
All jobs completed, we found the following issues.
Known Issues (From Taskcluster):
- test-macosx1015-64-qr/opt-gtest-1proc (NBNIpVNdTaeFkMbDmX5EQg) - new failure not classified
- test-windows11-32-2009-qr/opt-reftest-wr-dc2-o-1 (G80pg1_DRyqn4uwj07IxDQ) - new failure not classified
These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor media/libjxl/moz.yaml.)
In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.
|
||
Comment 11•2 years ago
|
||
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
Description
•