Closed Bug 1873541 Opened 2 years ago Closed 2 years ago

Avoid using GfxDriverInfo::allFeatures, convert uses to new optionalFeatures

Categories

(Core :: Graphics, defect, P3)

defect

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

optionalFeatures should include all features that return true in GfxInfoBase::OnlyAllowFeatureOnKnownConfig:
https://searchfox.org/mozilla-central/rev/43c40b22c776d098afb89d5237da3464a7545532/widget/GfxInfoBase.cpp#1523

Any hard coded blocklist entry using allFeatures should switch to optionalFeatures. That will allow us to try using the GPU process, as well as stop blocking WebGL OOP, ANGLE and backdrop filter.

These entries should affect relatively few users, but represent some of the last hold outs dropping the GPU process.

This patch makes it so that we avoid blocking all features with the
blocklist, and instead continue to allow the safe subset proscribed by
GfxInfoBase::OnlyAllowFeatureOnKnownConfig. Any feature allowed in an
unknown configuration should be allowed in a blanket blocklist entry,
unless we know for a fact that we need to also block them.

Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4dc4f0070bb9 Convert gfx blocklist entries for all features to subset excluding likely safe set. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: