Closed Bug 1873563 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 43890 - [IntersectionOptimization] Improve and fix cached rect invalidation

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43890 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43890
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

[IntersectionOptimization] Improve and fix cached rect invalidation

  • Move invalidation from
    ObjectPaintInvalidator::InvalidateDisplayItemClient to
    PaintInvalidator::InvalidatePaint because the former doesn't
    invalidate LayoutObjects that don't paint while these LayoutObjects
    can still observe intersection based on layout.
  • Rename InvalidateCachedRectsIfNeeded to
    InvalidateCachedRectsIfPaintPropertiesChange() because it only
    handles paint property changes but not local layout changes.
  • Skip scroll optimization if the cached rect is invalidated for other
    reasons.

Bug: 1400495, 1515283
Change-Id: Ib3015f13ac4280fc7a50e686982703eef3128812
Reviewed-on: https://chromium-review.googlesource.com/5154140
WPT-Export-Revision: ee0b011e19aaea9a98e31f4d93de4ca2fccf254c

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 3

Chrome

OK : 1
PASS: 3

Safari

OK : 1
PASS: 3

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06a9667efc47 [wpt PR 43890] - [IntersectionOptimization] Improve and fix cached rect invalidation, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.