1873648 - Rename AbortFollower to something that matches the latest spec

Status: NEW

(Core :: DOM: Core & HTML, task)

Description

[Vincent Hilla [:vhilla]]

Bug 1830781 implemented AbortSignal.any(). The according spec PR also removes the follow algorithm and mentions some follow-up work to remove its usages:

• https://github.com/whatwg/fetch/pull/1646
• https://github.com/w3c/ServiceWorker/pull/1678
• https://github.com/whatwg/streams/pull/1277

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

But we still need something corresponding to "add algorithm to AbortSignal" and so far AbortFollower was used for that internally. Can we just rename it and keep it?

Comment 2

[Vincent Hilla [:vhilla]]

Renaming seems like a good idea.

I briefly looked through the follow-up work and PR 1646 appears to be the only one that replaces a usage of follow with AbortSignal.any(). I'm not familiar with our fetch code, but it could be beneficial to replicate this change so that our implementation stays close to the spec.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

I don't think this needs dev doc? This should be just an internal refactoring.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

We should also remove AbortFollower inheritance in AbortSignal.