1873720 - [wpt-sync] Sync PR 43904 - Add helper functions to automatic beacon WPTs.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43904 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43904
Details from upstream follow.

Liam Brady <[e-mail]> wrote:

Add helper functions to automatic beacon WPTs.

This CL adds the following helper functions:

1. setupAutomaticBeacon(), which registers an automatic beacon inside a
   fenced frame/URN iframe context and sets up the click handler for the
   top-level navigation that will trigger the beacon. This can be
   customized using a new NavigationTrigger enum to handle clicks, clicks
   with a beacon whose once=true, and clicks in cross-origin subframes.
2. verifyBeaconData(), which replaces the existing boilerplate code
   needed in order to check the sent automatic beacon data as well as its
   initiator origin. This supports both the positive case as well as the
   negative timeout case.

The automatic beacon tests are refactored to use these new helper
functions.

Change-Id: Iff123d14ee1fd2ed075914db043addbb6f02638c

Reviewed-on: https://chromium-review.googlesource.com/5180049
WPT-Export-Revision: feed3b79a932712c62eb04bd467ab789af705cc5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff10a03d9e92e470d9ee34715f5803c5bc81567d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests

Status Summary

Firefox

OK : 12
FAIL : 12
ERROR: 1

Chrome

OK : 12
FAIL : 12
ERROR: 1

Safari

OK : 12
FAIL : 12
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fenced-frame/automatic-beacon-anchor-click-handler.https.html [wpt.fyi]
  • Set and trigger an automatic beacon in an <a> click handler: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-click-handler.https.html [wpt.fyi]
  • Set and trigger an automatic beacon in a click handler: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-component-ad.https.html [wpt.fyi]
  • Automatic beacon in an ad component should send without data with a header opt-in.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-cross-origin-false.https.html [wpt.fyi]
  • Automatic beacon in a cross-origin subframe should send without data when crossOrigin=false.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-cross-origin-navigation.https.html [wpt.fyi]
  • Automatic beacon in a cross-origin subframe: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-cross-origin-no-data.https.html [wpt.fyi]
  • Automatic beacon in a cross-origin subframe with no beacon data set: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-cross-origin-no-opt-in.https.html [wpt.fyi]
  • Automatic beacon in a cross-origin subframe with no opt-in header should not send.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-no-destination.https.html [wpt.fyi]
  • Set and trigger an automatic beacon with no destination specified: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-no-opt-in.https.html [wpt.fyi]
  • Automatic beacons will not send if the document does not opt in.: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-shared-storage.https.html [wpt.fyi]
  • Set and trigger an automatic beacon in a click handler for SharedStorage: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-two-events-clear.https.html [wpt.fyi]
  • Set expiring automatic beacon but trigger two events in a click handler: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-two-events-persist.https.html [wpt.fyi]
  • Set persisting automatic beacon but trigger two events in a click handler: FAIL (Chrome: FAIL, Safari: FAIL)
• /fenced-frame/automatic-beacon-unfenced-top.https.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ec1230acb5d
[wpt PR 43904] - Add helper functions to automatic beacon WPTs., a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8ec1230acb5d