1873788 - Bookmark keyword search and search mode search uses the default engine search when there is restrict symbol at the end of search string

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Mandy Cheang [:mcheang][she/her]]

While working on Bug 1667639 - Ending a keyword query with a question mark (?) searches default search engine instead and restricts to search Marco and I found another bug. This bug can manifest in two ways:

1 Bookmark keyword search

Steps To Reproduce:

1. Add a bookmark keyword
   a. Go to https://unsplash.com/
   b. Right click on the page's search bar
   c. Click on "Add a keyword for this search"
   d. Add "unsplash" as the keyword and save it.

2. Type unsplash kitten * onto Firefox's address bar

3. Hit enter and it will search unsplash kitten * on the default search engine.

Expected:
It should search kitten * on the unsplash website.

Actual:
It searched unsplash kitten * on the default engine search result page.

2 Alias Search

1. Navigate to about:preferences#search
2. Add a keyword for one the search engines. E.g. wiki for wikpedia
3. Copy wiki kitten? or wiki kitten ? (either one would work)
4. Right click the address bar by clicking Paste and Go
5. It searched wiki kitten? on the default search engine

Expected:
It should search kitten? on wikipedia.

Actual:
It searched kitten? on the default engine search result page.

Comment 1

[Mandy Cheang [:mcheang][she/her]]

This patch fixes all restrict symbols at the end EXCEPT it does not fix the ? restrict symbol. Another patch will be updated to fix the ? restrict symbol at the end of a search string in Bug 1667639.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1873788 - Fix bookmark keyword and alias search switching to default engine search when restrict symbols are at the end of the search string. r=mak!

search when restrict symbols are at the end of the search string. r=mak!

This patch does not fix the ? symbol at the end. That fix will be in Bug 1667639.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/251453e9c9c7
Fix bookmark keyword and alias search switching to default engine search when restrict symbols are at the end of the search string. r=mak

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/251453e9c9c7

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-01-09 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 123.0a1 on Windows 10, Ubuntu 22, macOS 12.

Scenario 1 - Bookmark keyword search is respected and kitten * is searched on Unsplash website.

Scenario 2 - Alias Search is respected. Once you Paste and Go the following string, wiki kitten ?, the search is made on Wikipedia.