1873860 - Check that the quickfilter API is correctly updating the quickfilter input field in Daily

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P1)

Description

[John Bieling (:TbSync)]

Example add-on: https://addons.thunderbird.net/de/thunderbird/addon/quickfilter-kbd/

Comment 1

[John Bieling (:TbSync)]

@aleca: You can reproduce this bug as follows:

• install the quickfilter-kbd add-on
• select a message with a subject you want to set the quickfilter to
• press shift + alt + s (a shortcut registered by the extension)
• observe the message list being filtered to messages with the same subject as the selected message
• observe the quickfilter box remaining empty

Comment 2

[Alessandro Castellani [:aleca]]

Is the add-on reaching directly into the DOM or passing through an API we offer?

The problem is that we stopped using the XUL search-textbox and moved to a simple HTML form with an HTML input field inside.
That template is used in this custom element and added to the shadowDOM.

Should we implement a method inside the SearchBar custom element to enable add-ons to reach into the input field and send strings?

Comment 3

[John Bieling (:TbSync)]

The add-on is using the API browser.mailTabs.setQuickFilter() and I need to restore the behavior.

I do not think that we need and API just to update the content, we need to make the content being updated when the setter is being used. Or I have to update the API to use a new setter (but I did not find one).

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: Bug 1873860 - Restore the ability to populate the quick filter search field for add-ons. r=#thunderbird-reviewers,john.bieling

Comment 5

[Martin Giger [:freaktechnik]]

Continuing this.

Comment 6

[Alessandro Castellani [:aleca]]

Raising the priority as this should land a couple of beta releases before next ESR.

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1873860 - Clean up QuickFilterManager JSDocs. r=#thunderbird-reviewers

Comment 8

[Martin Giger [:freaktechnik]]

Attachment: Bug 1873860 - Fix docs JSDoc build. r=#thunderbird-build-system-reviewers

Comment 9

[Martin Giger [:freaktechnik]]

Attachment: Bug 1873860 - Add documentation for Quick Filter Bar. r=heather,#thunderbird-front-end-reviewers

Comment 10

[Martin Giger [:freaktechnik]]

Attachment: Bug 1873860 - Fix quick filter bar API for extensions. r=john.bieling,#thunderbird-front-end-reviewers

Comment 11

[Martin Giger [:freaktechnik]]

Attachment: Bug 1873860 - Add test for quick filter bar extension API. r=john.bieling

Comment 12

[Martin Giger [:freaktechnik]]

The first three patches of the stack are ready to land at the time of writing.

Comment 13

[Martin Giger [:freaktechnik]]

Attachment: Bug 1873860 - Add test for search-bar overrideSearchTerm. r=#thunderbird-front-end-reviewers

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ce4ae1be6ac
Clean up QuickFilterManager JSDocs. r=vineet
https://hg.mozilla.org/comm-central/rev/f3534581a4ac
Fix docs JSDoc build. r=rjl
https://hg.mozilla.org/comm-central/rev/935c55c42eeb
Add documentation for Quick Filter Bar. r=heather,aleca

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1f79f652c55e
Fix quick filter bar API for extensions. r=john.bieling,aleca
https://hg.mozilla.org/comm-central/rev/24007c863bc5
Add test for quick filter bar extension API. r=john.bieling
https://hg.mozilla.org/comm-central/rev/8c438b9379a5
Add test for search-bar overrideSearchTerm. r=aleca