187392 - XUL Fastload doesn't serialize URL's like chrome://foo/content/foo.xul?whatever

Status: NEW

(Core :: XUL, defect)

Description

[John Morrison]

Not a biggie, really. Just noticed this in passing.

The help dialog uses URL's like: 'chrome://help/content/help.xul?chrome%3A...'.
In nsXULPrototypeCache::StartFastLoad, it will bail if the last 4 characters
of the path are not '.xul'. So, the fastload serialization will never occur
for help.xul (and I believe for any '.js' that it pulls in). Could use 
nsIURL's GetFileExtension instead, I suppose.

Comment 1

[John Morrison]

Whoops. Spoke too soon. This may be something to look into.

1) Shut down and delete XUL.mfasl
2) Start up in the browser.
3) Do 'Help->Help Topics'.
4) Quit and start again.
5) ###!!! ASSERTION: reading FastLoad?!: 'rv != NS_ERROR_NOT_AVAILABLE', 
   file h:/mozilla4/mozilla/content/xul/document/src/nsXULDocument.cpp, 
   line 5819

Hit twice for 'help.js' and for 'nsJSSupportsUtils.js' (pulled in by 
'help.xul'). (Note: nsXULDocument::OnStreamComplete properly ends the 
muxed document, so that's okay at least).

NTDLL! 77f9f9df()
nsDebug::Assertion(const char * 0x01a82530, const char * 0x01a82510, const char 
* 0x01a824d0, int 5819) line 280 + 13 bytes
nsXULDocument::OnStreamComplete(nsXULDocument * const 0x03726f44, 
nsIStreamLoader * 0x037aee60, nsISupports * 0x00000000, unsigned int 0, 
unsigned int 23267, const char * 0x037b4b40) line 5819 + 35 bytes
nsStreamLoader::OnStopRequest(nsStreamLoader * const 0x037aee64, nsIRequest * 
0x037aef40, nsISupports * 0x00000000, unsigned int 0) line 144
nsJARChannel::OnStopRequest(nsJARChannel * const 0x037aef44, nsIRequest * 
0x037774c4, nsISupports * 0x00000000, unsigned int 0) line 606 + 49 bytes
nsOnStopRequestEvent::HandleEvent() line 213
nsARequestObserverEvent::HandlePLEvent(PLEvent * 0x0378e07c) line 116
PL_HandleEvent(PLEvent * 0x0378e07c) line 663 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00f5a090) line 593 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00700474, unsigned int 49396, unsigned int 0, 
long 16097424) line 1379 + 9 bytes
USER32! 77e13eb0()
USER32! 77e1401a()
USER32! 77e13f0f()
nsAppShellService::Run(nsAppShellService * const 0x00fdfb68) line 472
main1(int 1, char * * 0x002779a8, nsISupports * 0x00277a20) line 1543 + 32 
bytes